Skip to content

docs-infra: backporting #28592, #28463, #28650, #28688, #28663 - #28714

Merged
mhevery merged 20 commits into
angular:7.2.xfrom
gkalpak:7.2.x-backport-stuff
Feb 14, 2019
Merged

docs-infra: backporting #28592, #28463, #28650, #28688, #28663#28714
mhevery merged 20 commits into
angular:7.2.xfrom
gkalpak:7.2.x-backport-stuff

Conversation

@gkalpak

@gkalpak gkalpak commented Feb 13, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Backporting #28592, #28463, #28650, #28688, #28663 to 7.2.x (except that the test_docs_examples_ivy job is disabled).
(This makes it easier to cherry-pick stuff from master into the patch branch in the future.)

@gkalpak
gkalpak requested a review from IgorMinar as a code owner February 13, 2019 23:29
@gkalpak
gkalpak requested review from a team February 13, 2019 23:29
@googlebot

googlebot commented Feb 13, 2019

Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@gkalpak gkalpak changed the title docs-infra: backporting #28592, #28463 and #28650 docs-infra: backporting #28592, #28463, #28650, 28663 Feb 13, 2019
@gkalpak
gkalpak force-pushed the 7.2.x-backport-stuff branch from 9adfd38 to 1d6c352 Compare February 13, 2019 23:37
@ngbot ngbot Bot added this to the needsTriage milestone Feb 13, 2019
@gkalpak
gkalpak force-pushed the 7.2.x-backport-stuff branch from 1d6c352 to a975691 Compare February 13, 2019 23:50
@gkalpak gkalpak changed the title docs-infra: backporting #28592, #28463, #28650, 28663 docs-infra: backporting #28592, #28463, #28650, #28663, #28688 Feb 13, 2019
@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker and removed state: WIP labels Feb 13, 2019
@ngbot

ngbot Bot commented Feb 13, 2019

Copy link
Copy Markdown

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure conflicts with base branch "7.2.x"
    pending missing required labels: cla: yes
    pending forbidden labels detected: cla: no
    pending missing required status "ci/circleci: publish_snapshot"
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@gkalpak

gkalpak commented Feb 13, 2019

Copy link
Copy Markdown
Member Author

merge-assistance: The legacy-unit-tests-saucelabs failure is not related to this PR. It is likely related to this Saucelabs partial outage and it is happening on other PRs too.

@gkalpak gkalpak added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Feb 13, 2019
@gkalpak gkalpak changed the title docs-infra: backporting #28592, #28463, #28650, #28663, #28688 docs-infra: backporting #28592, #28463, #28650, #28688, #28663 Feb 14, 2019
@brandonroberts @gkalpak
ci(docs-infra): run docs examples tests in production mode (angular#2…
99af597 
…8592)

PR Close angular#28592
@brandonroberts @gkalpak
docs: remove quickstart example and copy tsconfig.1.json into TS conf…
72ad5d5 
…ig guide (angular#28592)

This example has long been replaced by the cli-quickstart, but was never deleted.

PR Close angular#28592
@brandonroberts @gkalpak
docs: enable E2E test for setup example (angular#28592)
2829516 
This guide is not being shown publicly, and its test is currently being ignored.
Instead of deleting this test and guide, it may be repurposed in the future for a local development guide.

PR Close angular#28592
@brandonroberts @gkalpak
docs: ignore progression filenames from compilation (angular#28592)
5952bb7 
PR Close angular#28592
@brandonroberts @gkalpak
docs: remove unused StringSafeDatePipe from AngularJS Quick Ref examp…
c20ef65 
…le (angular#28592)

PR Close angular#28592
@brandonroberts @gkalpak
docs: make parent finder functions compatible with AoT (angular#28592)
f882947 
PR Close angular#28592
@brandonroberts @gkalpak
docs: make toggleImage arguments optional in AngularJS quick reference (
ed73408 
angular#28592)

PR Close angular#28592
@brandonroberts @gkalpak
docs: add insert remove component to AppModule for animations example (…
e736d03 
…angular#28592)

PR Close angular#28592
@brandonroberts @gkalpak
docs: ignore component for app compilation for displaying data example (
2671b1d 
angular#28592)

PR Close angular#28592
@brandonroberts @gkalpak
docs: ignore files from app compilation for ngmodule-faq example (ang…
c25db3a 
…ular#28592)

PR Close angular#28592
@brandonroberts @gkalpak
docs: ignore initial components for app compilation in router example (…
69ced95 
…angular#28592)

PR Close angular#28592
@brandonroberts @gkalpak
docs: remove unused files in styleguide example (angular#28592)
3f78a56 
PR Close angular#28592
@brandonroberts @gkalpak
docs: make method arguments optional in template syntax example (angu…
011b020 
…lar#28592)

PR Close angular#28592
@brandonroberts @gkalpak
docs: add more files to be ignored during app compilation (angular#28592
ea86cee 
)

PR Close angular#28592
@brandonroberts @gkalpak
docs: run component-interaction and DI in JiT mode (angular#28592)
1aa0196 
PR Close angular#28592
@brandonroberts @gkalpak
docs: re-enable E2E tests for Http guide (angular#28592)
828b1f6 
PR Close angular#28592
@gkalpak
gkalpak force-pushed the 7.2.x-backport-stuff branch from a975691 to 502c741 Compare February 14, 2019 00:19
@gkalpak
gkalpak force-pushed the 7.2.x-backport-stuff branch from 502c741 to 10cc475 Compare February 14, 2019 00:21
@mhevery mhevery added cla: yes and removed cla: no labels Feb 14, 2019
@googlebot

googlebot commented Feb 14, 2019

Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@mhevery
mhevery merged commit a873fab into angular:7.2.x Feb 14, 2019
@gkalpak
gkalpak deleted the 7.2.x-backport-stuff branch February 14, 2019 11:09
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 14, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@IgorMinar IgorMinar Awaiting requested review from IgorMinar
1 more reviewer
@mhevery mhevery mhevery approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note type: bug/fix

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

6 participants

@gkalpak @googlebot @mhevery @brandonroberts @marclaval @kapunahelewong