Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
23daa14
ci(docs-infra): run docs examples tests in production mode (#28592)
brandonroberts Feb 7, 2019
a0589d3
docs: remove quickstart example and copy tsconfig.1.json into TS conf…
brandonroberts Feb 7, 2019
467f8e1
docs: enable E2E test for setup example (#28592)
brandonroberts Feb 7, 2019
f9f3c0f
docs: ignore progression filenames from compilation (#28592)
brandonroberts Feb 7, 2019
47fb2c5
docs: remove unused StringSafeDatePipe from AngularJS Quick Ref examp…
brandonroberts Feb 7, 2019
68f38f9
docs: make parent finder functions compatible with AoT (#28592)
brandonroberts Feb 7, 2019
d7ef402
docs: make toggleImage arguments optional in AngularJS quick referenc…
brandonroberts Feb 7, 2019
e5f213b
docs: add insert remove component to AppModule for animations example…
brandonroberts Feb 7, 2019
ccebec9
docs: ignore component for app compilation for displaying data exampl…
brandonroberts Feb 7, 2019
9d1c39c
docs: ignore files from app compilation for ngmodule-faq example (#28…
brandonroberts Feb 7, 2019
a531450
docs: ignore initial components for app compilation in router example…
brandonroberts Feb 7, 2019
ed1e788
docs: remove unused files in styleguide example (#28592)
brandonroberts Feb 7, 2019
c9f0d83
docs: make method arguments optional in template syntax example (#28592)
brandonroberts Feb 7, 2019
661948f
docs: add more files to be ignored during app compilation (#28592)
brandonroberts Feb 7, 2019
4a167a2
docs: run component-interaction and DI in JiT mode (#28592)
brandonroberts Feb 7, 2019
155b36f
docs: re-enable E2E tests for Http guide (#28592)
brandonroberts Feb 7, 2019
d2deab3
ci(docs-infra): test docs examples with Ivy (#28463)
brandonroberts Feb 5, 2019
e440e7e
fix(docs-infra): add progression files to exclude list for docs examp…
brandonroberts Feb 11, 2019
9adfd38
WIP
gkalpak Feb 13, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,27 @@ jobs:
# with either "0", "1" or "2" as node index. This can be passed to the "--shard" argument.
- run: yarn --cwd aio example-e2e --setup --local --shard=${CIRCLE_NODE_INDEX}/${CIRCLE_NODE_TOTAL}

test_docs_examples_ivy:
<<: *job_defaults
docker:
# Needed because the example e2e tests depend on Chrome.
- image: *browsers_docker_image
parallelism: 3
steps:
- checkout:
<<: *post_checkout
- *restore_cache
- attach_workspace:
at: dist
- *define_env_vars
- *download_yarn
# Install aio
- run: yarn --cwd aio install --frozen-lockfile --non-interactive
# Run examples tests with ivy. The "CIRCLE_NODE_INDEX" will be set if "parallelism" is enabled.
# Since the parallelism is set to "3", there will be three parallel CircleCI containers
# with either "0", "1" or "2" as node index. This can be passed to the "--shard" argument.
- run: yarn --cwd aio example-e2e --setup --local --ivy --shard=${CIRCLE_NODE_INDEX}/${CIRCLE_NODE_TOTAL}

# This job should only be run on PR builds, where `CI_PULL_REQUEST` is not `false`.
aio_preview:
<<: *job_defaults
Expand Down Expand Up @@ -547,6 +568,9 @@ workflows:
- test_docs_examples:
requires:
- build-npm-packages
- test_docs_examples_ivy:
requires:
- build-npm-packages
- aio_preview:
# Only run on PR builds. (There can be no previews for non-PR builds.)
filters:
Expand All @@ -572,7 +596,8 @@ workflows:
- test_aio_local
# - test_aio_local_ivy
- test_docs_examples
# Get the artifacts to publish from the build-npm-packages job
# - test_docs_examples_ivy
# Get the artifacts to publish from the build-packages-dist job
# since the publishing script expects the legacy outputs layout.
- build-npm-packages
- legacy-misc-tests
Expand Down
6 changes: 6 additions & 0 deletions aio/content/examples/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,9 @@ dist/

# aot
**/*.ngsummary.json
upgrade-module/tsconfig-aot.json
!rollup-config.js
upgrade-module/rollup-config.js
aot-compiler/**/*.d.ts
aot-compiler/**/*.factory.d.ts
upgrade-phonecat-2-hybrid/aot/**/*
Expand All @@ -84,5 +86,9 @@ upgrade-phonecat-2-hybrid/aot/**/*
*stackblitz.no-link.html

# ngUpgrade testing
upgrade-phonecat-1-typescript/tsconfig-aot.json
upgrade-phonecat-1-typescript/rollup-config.js
upgrade-phonecat-3-final/tsconfig-aot.json
upgrade-phonecat-3-final/rollup-config.js
!upgrade-phonecat-*/**/karma.conf.js
!upgrade-phonecat-*/**/karma-test-shim.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export class AppComponent {
movies: IMovie[] = [];
showImage = true;
title = 'AngularJS to Angular Quick Ref Cookbook';
toggleImage(event: UIEvent) {
toggleImage(event?: UIEvent) {
this.showImage = !this.showImage;
this.eventType = (event && event.type) || 'not provided';
}
Expand Down
14 changes: 0 additions & 14 deletions aio/content/examples/ajs-quick-reference/src/app/date.pipe.ts

This file was deleted.

2 changes: 2 additions & 0 deletions aio/content/examples/animations/src/app/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import { HeroListAutoCalcPageComponent } from './hero-list-auto-page.component';
import { HeroListAutoComponent } from './hero-list-auto.component';
import { HomeComponent } from './home.component';
import { AboutComponent } from './about.component';
import { InsertRemoveComponent } from './insert-remove.component';


@NgModule({
Expand Down Expand Up @@ -56,6 +57,7 @@ import { AboutComponent } from './about.component';
HeroListAutoCalcPageComponent,
HeroListAutoComponent,
HomeComponent,
InsertRemoveComponent,
AboutComponent
],
bootstrap: [AppComponent]
Expand Down
11 changes: 11 additions & 0 deletions aio/content/examples/component-interaction/example-config.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"e2e": [
{
"cmd": "yarn",
"args": [
"e2e",
"--no-webdriver-update"
]
}
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -19,20 +19,20 @@ const DifferentParent = Parent;
// #enddocregion provide-the-parent
// The `parentType` defaults to `Parent` when omitting the second parameter.
// #docregion provide-the-parent
const provideParent =
export function provideParent
// #enddocregion provide-parent, provide-the-parent
// #docregion provide-parent
(component: any, parentType?: any) => {
(component: any, parentType?: any) {
return { provide: parentType || Parent, useExisting: forwardRef(() => component) };
};
}
// #enddocregion provide-parent

// Simpler syntax version that always provides the component in the name of `Parent`.
const provideTheParent =
export function provideTheParent
// #docregion provide-the-parent
(component: any) => {
(component: any) {
return { provide: Parent, useExisting: forwardRef(() => component) };
};
}
// #enddocregion provide-the-parent


Expand Down
11 changes: 11 additions & 0 deletions aio/content/examples/dependency-injection/example-config.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"e2e": [
{
"cmd": "yarn",
"args": [
"e2e",
"--no-webdriver-update"
]
}
]
}
5 changes: 1 addition & 4 deletions aio/content/examples/http/e2e/src/app.e2e-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,7 @@ let checkLogForMessage = (message: string) => {
expect(page.logList.getText()).toContain(message);
};

// TODO(i): temorarily disable these tests because angular-in-memory-web-api is not compatible with rxjs v6 yet
// and we don't have the backwards compatibility package yet.
// Reenable after rxjs v6 compatibility package is out or angular-in-memory-web-api is compatible with rxjs v6
xdescribe('Http Tests', function() {
describe('Http Tests', function() {
beforeEach(() => {
browser.get('');
});
Expand Down
13 changes: 11 additions & 2 deletions aio/content/examples/i18n/example-config.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
{
"projectType": "i18n"
}
"projectType": "i18n",
"e2e": [
{
"cmd": "yarn",
"args": [
"e2e",
"--no-webdriver-update"
]
}
]
}
4 changes: 2 additions & 2 deletions aio/content/examples/ngmodule-faq/src/app/app.module.3.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ import { AppComponent } from './app.component';
// #enddocregion
*/
// #docregion
import { HighlightDirective } from './highlight.directive';
import { TitleComponent } from './title.component';
import { HighlightDirective } from './highlight.directive.1';
import { TitleComponent } from './title.component.1';
import { UserService } from './user.service';

/* Routing Module */
Expand Down
10 changes: 0 additions & 10 deletions aio/content/examples/ngmodule-faq/src/app/contact/awesome.pipe.ts

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { UserService } from './user.service';

@Component({
selector: 'app-title',
templateUrl: './title.component.html'
templateUrl: './title.component.1.html'
})
export class TitleComponent {
title = 'Angular Modules';
Expand Down
8 changes: 0 additions & 8 deletions aio/content/examples/quickstart/bs-config.1.json

This file was deleted.

8 changes: 0 additions & 8 deletions aio/content/examples/quickstart/src/app/app.component.ts

This file was deleted.

11 changes: 0 additions & 11 deletions aio/content/examples/quickstart/src/app/app.module.ts

This file was deleted.

31 changes: 0 additions & 31 deletions aio/content/examples/quickstart/src/index.html

This file was deleted.

5 changes: 0 additions & 5 deletions aio/content/examples/quickstart/src/main.ts

This file was deleted.

13 changes: 0 additions & 13 deletions aio/content/examples/quickstart/src/tsconfig.1.json

This file was deleted.

11 changes: 0 additions & 11 deletions aio/content/examples/quickstart/stackblitz.json

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { Component } from '@angular/core';

@Component({
selector: 'app-crisis-list',
templateUrl: './crisis-list.component.html',
styleUrls: ['./crisis-list.component.css']
templateUrl: './crisis-list.component.1.html',
styleUrls: ['./crisis-list.component.1.css']
})
export class CrisisListComponent { }
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { Component } from '@angular/core';

@Component({
selector: 'app-hero-list',
templateUrl: './hero-list.component.html',
styleUrls: ['./hero-list.component.css']
templateUrl: './hero-list.component.1.html',
styleUrls: ['./hero-list.component.1.css']
})
export class HeroListComponent { }
Empty file.
17 changes: 0 additions & 17 deletions aio/content/examples/setup/e2e-spec.ts

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// #docregion
export * from './spinner.component';
export * from './spinner.service';
Loading