Skip to content

docs-infra: backporting #28592, #28463 and #28650 - #28713

Closed
gkalpak wants to merge 19 commits into
angular:7.2.xfrom
gkalpak:7.2.x-backport-stuff
Closed

docs-infra: backporting #28592, #28463 and #28650#28713
gkalpak wants to merge 19 commits into
angular:7.2.xfrom
gkalpak:7.2.x-backport-stuff

Conversation

@gkalpak

@gkalpak gkalpak commented Feb 13, 2019

Copy link
Copy Markdown
Member

Backporting #28592, #28463 and #28650 to 7.2.x.

brandonroberts and others added 19 commits February 14, 2019 01:16
@brandonroberts @gkalpak
ci(docs-infra): run docs examples tests in production mode (angular#2…
23daa14 
…8592)

PR Close angular#28592
@brandonroberts @gkalpak
docs: remove quickstart example and copy tsconfig.1.json into TS conf…
a0589d3 
…ig guide (angular#28592)

This example has long been replaced by the cli-quickstart, but was never deleted.

PR Close angular#28592
@brandonroberts @gkalpak
docs: enable E2E test for setup example (angular#28592)
467f8e1 
This guide is not being shown publicly, and its test is currently being ignored.
Instead of deleting this test and guide, it may be repurposed in the future for a local development guide.

PR Close angular#28592
@brandonroberts @gkalpak
docs: ignore progression filenames from compilation (angular#28592)
f9f3c0f 
PR Close angular#28592
@brandonroberts @gkalpak
docs: remove unused StringSafeDatePipe from AngularJS Quick Ref examp…
47fb2c5 
…le (angular#28592)

PR Close angular#28592
@brandonroberts @gkalpak
docs: make parent finder functions compatible with AoT (angular#28592)
68f38f9 
PR Close angular#28592
@brandonroberts @gkalpak
docs: make toggleImage arguments optional in AngularJS quick reference (
d7ef402 
angular#28592)

PR Close angular#28592
@brandonroberts @gkalpak
docs: add insert remove component to AppModule for animations example (…
e5f213b 
…angular#28592)

PR Close angular#28592
@brandonroberts @gkalpak
docs: ignore component for app compilation for displaying data example (
ccebec9 
angular#28592)

PR Close angular#28592
@brandonroberts @gkalpak
docs: ignore files from app compilation for ngmodule-faq example (ang…
9d1c39c 
…ular#28592)

PR Close angular#28592
@brandonroberts @gkalpak
docs: ignore initial components for app compilation in router example (…
a531450 
…angular#28592)

PR Close angular#28592
@brandonroberts @gkalpak
docs: remove unused files in styleguide example (angular#28592)
ed1e788 
PR Close angular#28592
@brandonroberts @gkalpak
docs: make method arguments optional in template syntax example (angu…
c9f0d83 
…lar#28592)

PR Close angular#28592
@brandonroberts @gkalpak
docs: add more files to be ignored during app compilation (angular#28592
661948f 
)

PR Close angular#28592
@brandonroberts @gkalpak
docs: run component-interaction and DI in JiT mode (angular#28592)
4a167a2 
PR Close angular#28592
@brandonroberts @gkalpak
docs: re-enable E2E tests for Http guide (angular#28592)
155b36f 
PR Close angular#28592
@brandonroberts @gkalpak
ci(docs-infra): test docs examples with Ivy (angular#28463)
d2deab3 
PR Close angular#28463
@brandonroberts @gkalpak
fix(docs-infra): add progression files to exclude list for docs examp…
e440e7e 
…les (angular#28650)

Also disables Http guide under Ivy tests with documented error

PR Close angular#28650
@gkalpak
WIP
9adfd38
@gkalpak
gkalpak requested a review from IgorMinar as a code owner February 13, 2019 23:27
@gkalpak
gkalpak requested review from a team February 13, 2019 23:27
@gkalpak
gkalpak requested review from a team February 13, 2019 23:27
@gkalpak
gkalpak changed the base branch from master to 7.2.x February 13, 2019 23:28
@gkalpak gkalpak closed this Feb 13, 2019
@googlebot

googlebot commented Feb 13, 2019

Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 14, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@IgorMinar IgorMinar Awaiting requested review from IgorMinar

Assignees

No one assigned

Labels

cla: no

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gkalpak @googlebot @brandonroberts