feat(ivy): convert [ngStyle] and [ngClass] to use ivy styling bindings by matsko · Pull Request #28711 · angular/angular

matsko · 2019-02-13T22:25:14Z

Prior to this fix, both the NgStyle and NgClass directives made use
of Renderer2 and this dependency raised issues for future versions of
Angular that cannot inject it. This patch ensures that there are two
versions of both directives: one for the VE and another for Ivy.

matsko · 2019-02-15T21:55:37Z

https://tap.corp.google.com/ui#id=OCL:234186770:BASE:234205915:1550267312708:c5096264

gkalpak · 2019-02-17T11:22:38Z

This has now been fixed in master (via #28773).

mhevery · 2019-02-19T19:55:31Z

Why are these exports needed?

mhevery · 2019-02-19T19:56:33Z

Suggested change

* If the VE is not present then NgStyle will normailze (through the injected service) and

* If the VE is not present then NgStyle will normalize (through the injected service) and

mhevery · 2019-02-19T20:07:07Z

Any particular reason why this code was pulled into a separate file?

mhevery · 2019-02-19T20:08:34Z

Suggested change

* of how [style] and [class] behave in Angluar.

* of how [style] and [class] behave in Angular.

mhevery · 2019-02-19T20:09:44Z

Suggested change

* the inner guts of the binding value have changed.

* the inner representation of the binding value have changed.

mhevery · 2019-02-19T20:12:04Z

give an example. Right now the reader has no way of guessing wha the given the right combination of events are

mhevery · 2019-02-19T20:13:43Z

mhevery · 2019-02-19T20:15:40Z

Something is wrong here. The public API reffers to NgClassBase but it is not shown here. Same issue for NgStyleBase

mhevery · 2019-02-19T20:17:35Z

Suggested change

* If the VE is not present then NgClass will normailze (through the injected service) and

* If the VE is not present then NgClass will normalize (through the injected service) and

mhevery · 2019-02-19T20:17:54Z

Suggested change

* then write all styling changes to the `[class]` binding directly (through a host binding).

* then write all styling changes to the `[style]` binding directly (through a host binding).

Prior to this fix, using the compiler's ivy_switch mechanism was only available to core packages. This patch allows for this variable switching mechanism to work across all other angular packages.

Prior to this fix, both the `NgStyle` and `NgClass` directives made use of `Renderer2` and this dependency raised issues for future versions of Angular that cannot inject it. This patch ensures that there are two versions of both directives: one for the VE and another for Ivy. Jira Issue: FW-882

…bindings

#28711) Prior to this fix, both the `NgStyle` and `NgClass` directives made use of `Renderer2` and this dependency raised issues for future versions of Angular that cannot inject it. This patch ensures that there are two versions of both directives: one for the VE and another for Ivy. Jira Issue: FW-882 PR Close #28711

Prior to this fix, using the compiler's ivy_switch mechanism was only available to core packages. This patch allows for this variable switching mechanism to work across all other angular packages. PR Close angular#28711

angular#28711) Prior to this fix, both the `NgStyle` and `NgClass` directives made use of `Renderer2` and this dependency raised issues for future versions of Angular that cannot inject it. This patch ensures that there are two versions of both directives: one for the VE and another for Ivy. Jira Issue: FW-882 PR Close angular#28711

angular-automatic-lock-bot · 2019-09-14T17:51:54Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

matsko requested review from a team February 13, 2019 22:25

googlebot added the cla: yes label Feb 13, 2019

matsko changed the title ~~feat(ivy): convert [ngStyle] and [ngClass] to use ivy styling bindings~~ wip: feat(ivy): convert [ngStyle] and [ngClass] to use ivy styling bindings Feb 13, 2019

matsko force-pushed the ng_style_ng_class branch 2 times, most recently from 190d476 to 4ec5446 Compare February 13, 2019 23:41

matsko requested a review from a team February 13, 2019 23:41

matsko force-pushed the ng_style_ng_class branch from 4ec5446 to 667e1ee Compare February 13, 2019 23:53

matsko requested a review from a team February 13, 2019 23:53

matsko force-pushed the ng_style_ng_class branch 8 times, most recently from 0e0d7a5 to e5cccfe Compare February 15, 2019 21:44

matsko added the target: major This PR is targeted for the next major release label Feb 15, 2019

matsko changed the title ~~wip: feat(ivy): convert [ngStyle] and [ngClass] to use ivy styling bindings~~ feat(ivy): convert [ngStyle] and [ngClass] to use ivy styling bindings Feb 15, 2019

matsko force-pushed the ng_style_ng_class branch from e5cccfe to 6ce138d Compare February 16, 2019 01:03

gkalpak reviewed Feb 17, 2019

View reviewed changes

matsko force-pushed the ng_style_ng_class branch 3 times, most recently from 4c45e90 to f7f77df Compare February 19, 2019 19:37

mhevery suggested changes Feb 19, 2019

View reviewed changes

benlesh added the area: common Issues related to APIs in the @angular/common package label Feb 20, 2019

ngbot Bot added this to the needsTriage milestone Feb 20, 2019

matsko force-pushed the ng_style_ng_class branch from f7f77df to 1288fd9 Compare February 20, 2019 19:09

feat(ivy): open up ivy_switch_mode to non-core packages

14182a2

Prior to this fix, using the compiler's ivy_switch mechanism was only available to core packages. This patch allows for this variable switching mechanism to work across all other angular packages.

matsko force-pushed the ng_style_ng_class branch from 1288fd9 to d2ec816 Compare February 20, 2019 20:47

mhevery approved these changes Feb 20, 2019

View reviewed changes

fixup! feat(ivy): convert [ngStyle] and [ngClass] to use ivy styling …

4eece8d

…bindings

matsko added the action: merge The PR is ready for merge by the caretaker label Feb 20, 2019

benlesh closed this in 2cd9c6e Feb 20, 2019

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019

	* If the VE is not present then NgStyle will normailze (through the injected service) and
	* If the VE is not present then NgStyle will normalize (through the injected service) and

	* of how [style] and [class] behave in Angluar.
	* of how [style] and [class] behave in Angular.

	* the inner guts of the binding value have changed.
	* the inner representation of the binding value have changed.

	* If the VE is not present then NgClass will normailze (through the injected service) and
	* If the VE is not present then NgClass will normalize (through the injected service) and

	* then write all styling changes to the `[class]` binding directly (through a host binding).
	* then write all styling changes to the `[style]` binding directly (through a host binding).

Conversation

matsko commented Feb 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matsko commented Feb 15, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

angular-automatic-lock-bot Bot commented Sep 14, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

matsko commented Feb 13, 2019 •

edited

Loading