Skip to content

test(ivy): enable more docs examples e2e tests #28688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marclaval wants to merge 1 commit into from
Closed

test(ivy): enable more docs examples e2e tests #28688

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 5 additions & 16 deletions aio/tools/examples/run-example-e2e.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,26 +21,16 @@ const IGNORED_EXAMPLES = [
];

const fixmeIvyExamples = [
// fixmeIvy('unknown') movie list route is not rendering
'ajs-quick-reference',
// fixmeIvy('unknown') version value goes undefined when clicking Major button after clicking
// Minor button twice
'component-interaction',
// fixmeIvy('unknown') failed content projection and applied styles
'component-styles',
// fails due to incompatible AoT code with a tree-shakable provider and a non-type constructor
// argument
'dependency-injection',
// fixmeIvy('unknown') Error: Internal Error: The name heroForm is already defined in scope to be
// [object Object]
'forms',
// fixmeIvy('unknown') ERROR Error: Unable to find context associated with [object HTMLInputElement]
// fixmeIvy('unknown') ERROR Error: Unable to find context associated with [object
// HTMLInputElement]
'http',
// fixmeIvy('unknown') app fails at runtime due to missing external service (goog is undefined)
'i18n',
// fixmeIvy('unknown') ERROR in HostResourceResolver: could not resolve app/app.component.css
// in context of aio/content/examples/styleguide/src/01-01/app/heroes/hero.component.avoid.ts)
'styleguide'
'i18n'
];

if (argv.ivy) {
Expand Down Expand Up @@ -236,8 +226,7 @@ function runE2eTestsCLI(appDir, outputFile) {
console.log(`\n\n=========== Running aio example tests for: ${appDir}`);
// `--no-webdriver-update` is needed to preserve the ChromeDriver version already installed.
const config = loadExampleConfig(appDir);
const commands = config.e2e ||
[{cmd: 'yarn', args: ['e2e', '--prod', '--no-webdriver-update']}];
const commands = config.e2e || [{cmd: 'yarn', args: ['e2e', '--prod', '--no-webdriver-update']}];

const e2eSpawnPromise = commands.reduce((prevSpawnPromise, {cmd, args}) => {
return prevSpawnPromise.then(() => {
Expand Down Expand Up @@ -336,7 +325,7 @@ function getE2eSpecs(basePath, filter) {
// Find all e2e specs in a given example folder.
function getE2eSpecsFor(basePath, specFile, filter) {
// Only get spec file at the example root.
const e2eSpecGlob = `${filter ? ` * ${filter} * ` : '*'}/${specFile}`;
const e2eSpecGlob = `${filter ? '*' + filter + '*' : '*'}/${specFile}`;
return globby(e2eSpecGlob, {cwd: basePath, nodir: true})
.then(
paths => paths.filter(file => !IGNORED_EXAMPLES.some(ignored => file.startsWith(ignored)))
Expand Down