Skip to content

test(ivy): enable more docs examples e2e tests - #28688

Closed
marclaval wants to merge 1 commit into
angular:masterfrom
marclaval:aioE2eActivate
Closed

marclaval wants to merge 1 commit into
angular:masterfrom
marclaval:aioE2eActivate

Conversation

@marclaval

Copy link
Copy Markdown
Contributor

A number of tests are actually passing

@marclaval
marclaval requested a review from a team February 13, 2019 13:33
@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release comp: docs-infra labels Feb 13, 2019
@ngbot ngbot Bot added this to the needsTriage milestone Feb 13, 2019
@gkalpak gkalpak added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Feb 13, 2019
@gkalpak

gkalpak commented Feb 13, 2019

Copy link
Copy Markdown
Member

@marclaval, could you change the commit message to something like:

test(ivy): enable more docs examples e2e tests

or

test(docs-infra): enable more docs examples e2e tests with ivy

@marclaval

Copy link
Copy Markdown
Contributor Author

@gkalpak I've update the commit message

@gkalpak gkalpak changed the title test(ivy): enable more aio e2e tests test(ivy): enable more docs examples e2e tests Feb 13, 2019
@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 13, 2019
@mhevery mhevery closed this in f8b9e61 Feb 13, 2019
mhevery pushed a commit that referenced this pull request Feb 13, 2019
mhevery added a commit to mhevery/angular that referenced this pull request Feb 13, 2019
mhevery added a commit that referenced this pull request Feb 13, 2019
gkalpak pushed a commit to gkalpak/angular that referenced this pull request Feb 14, 2019
mhevery pushed a commit that referenced this pull request Feb 14, 2019
* ci(docs-infra): run docs examples tests in production mode (#28592)

PR Close #28592

* docs: remove quickstart example and copy tsconfig.1.json into TS config guide (#28592)

This example has long been replaced by the cli-quickstart, but was never deleted.

PR Close #28592

* docs: enable E2E test for setup example (#28592)

This guide is not being shown publicly, and its test is currently being ignored.
Instead of deleting this test and guide, it may be repurposed in the future for a local development guide.

PR Close #28592

* docs: ignore progression filenames from compilation (#28592)

PR Close #28592

* docs: remove unused StringSafeDatePipe from AngularJS Quick Ref example (#28592)

PR Close #28592

* docs: make parent finder functions compatible with AoT (#28592)

PR Close #28592

* docs: make toggleImage arguments optional in AngularJS quick reference (#28592)

PR Close #28592

* docs: add insert remove component to AppModule for animations example (#28592)

PR Close #28592

* docs: ignore component for app compilation for displaying data example (#28592)

PR Close #28592

* docs: ignore files from app compilation for ngmodule-faq example (#28592)

PR Close #28592

* docs: ignore initial components for app compilation in router example (#28592)

PR Close #28592

* docs: remove unused files in styleguide example (#28592)

PR Close #28592

* docs: make method arguments optional in template syntax example (#28592)

PR Close #28592

* docs: add more files to be ignored during app compilation (#28592)

PR Close #28592

* docs: run component-interaction and DI in JiT mode (#28592)

PR Close #28592

* docs: re-enable E2E tests for Http guide (#28592)

PR Close #28592

* ci(docs-infra): test docs examples with Ivy (#28463)

PR Close #28463

* fix(docs-infra): add progression files to exclude list for docs examples (#28650)

Also disables Http guide under Ivy tests with documented error

PR Close #28650

* fix(docs-infra): fix filtering in run-example-e2e.js (#28663)

PR Close #28663

* test(ivy): enable more docs examples e2e tests (#28688)

PR Close #28688
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants