Repository navigation
fix(docs-infra): fix filtering in run-example-e2e.js - #28663
Closed
kapunahelewong wants to merge 1 commit into
Closed
kapunahelewong wants to merge 1 commit into
kapunahelewong wants to merge 1 commit into
Conversation
kapunahelewong
added
the
target: patch
brandonroberts
approved these changes
Feb 12, 2019
brandonroberts
added
target: major
gkalpak
approved these changes
Feb 13, 2019
gkalpak
left a comment
gkalpak
left a comment
Member
There was a problem hiding this comment.
Ooops!
The current commit messages makes it sound as if this is a formatting fix, not a bug fix. Can you, please, change it to something like:
fix(doc-infra): fix filtering in `run-example-e2e.js`
gkalpak
added
the
action: cleanup
kapunahelewong
changed the title
run-example-e2e.js
Contributor
Author
Fixed. Thanks for looking out @gkalpak. I feel so...pioneering! |
kapunahelewong
changed the title
run-example-e2e.js
Member
|
Thx, @kapunahelewong! Can you also rebase on master to get CI green? 🙏 |
Contributor
Author
|
@gkalpak Done! |
gkalpak
added
action: merge
gkalpak
pushed a commit
to gkalpak/angular
that referenced
this pull request
Feb 14, 2019
mhevery
pushed a commit
that referenced
this pull request
Feb 14, 2019
* ci(docs-infra): run docs examples tests in production mode (#28592) PR Close #28592 * docs: remove quickstart example and copy tsconfig.1.json into TS config guide (#28592) This example has long been replaced by the cli-quickstart, but was never deleted. PR Close #28592 * docs: enable E2E test for setup example (#28592) This guide is not being shown publicly, and its test is currently being ignored. Instead of deleting this test and guide, it may be repurposed in the future for a local development guide. PR Close #28592 * docs: ignore progression filenames from compilation (#28592) PR Close #28592 * docs: remove unused StringSafeDatePipe from AngularJS Quick Ref example (#28592) PR Close #28592 * docs: make parent finder functions compatible with AoT (#28592) PR Close #28592 * docs: make toggleImage arguments optional in AngularJS quick reference (#28592) PR Close #28592 * docs: add insert remove component to AppModule for animations example (#28592) PR Close #28592 * docs: ignore component for app compilation for displaying data example (#28592) PR Close #28592 * docs: ignore files from app compilation for ngmodule-faq example (#28592) PR Close #28592 * docs: ignore initial components for app compilation in router example (#28592) PR Close #28592 * docs: remove unused files in styleguide example (#28592) PR Close #28592 * docs: make method arguments optional in template syntax example (#28592) PR Close #28592 * docs: add more files to be ignored during app compilation (#28592) PR Close #28592 * docs: run component-interaction and DI in JiT mode (#28592) PR Close #28592 * docs: re-enable E2E tests for Http guide (#28592) PR Close #28592 * ci(docs-infra): test docs examples with Ivy (#28463) PR Close #28463 * fix(docs-infra): add progression files to exclude list for docs examples (#28650) Also disables Http guide under Ivy tests with documented error PR Close #28650 * fix(docs-infra): fix filtering in run-example-e2e.js (#28663) PR Close #28663 * test(ivy): enable more docs examples e2e tests (#28688) PR Close #28688
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
e2e tests for docs examples not running properly on master.
Issue Number: N/A
What is the new behavior?
Change from
* ${filter} *to*${filter}*(no spaces).Does this PR introduce a breaking change?
Other information
For context: #28463