Skip to content

fix(docs-infra): add progression files to exclude list for docs examples #28650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brandonroberts wants to merge 1 commit into from
Closed

fix(docs-infra): add progression files to exclude list for docs examples #28650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion aio/tools/examples/run-example-e2e.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ const fixmeIvyExamples = [
// fixmeIvy('unknown') Error: Internal Error: The name heroForm is already defined in scope to be
// [object Object]
'forms',
// fixmeIvy('unknown') ERROR Error: Unable to find context associated with [object HTMLInputElement]
'http',
// fixmeIvy('unknown') app fails at runtime due to missing external service (goog is undefined)
'i18n',
// fixmeIvy('unknown') ERROR in HostResourceResolver: could not resolve app/app.component.css
Expand Down Expand Up @@ -235,7 +237,7 @@ function runE2eTestsCLI(appDir, outputFile) {
// `--no-webdriver-update` is needed to preserve the ChromeDriver version already installed.
const config = loadExampleConfig(appDir);
const commands = config.e2e ||
[{cmd: 'yarn', args: ['e2e', (argv.ivy ? '--prod' : ''), '--no-webdriver-update']}];
[{cmd: 'yarn', args: ['e2e', '--prod', '--no-webdriver-update']}];

const e2eSpawnPromise = commands.reduce((prevSpawnPromise, {cmd, args}) => {
return prevSpawnPromise.then(() => {
Expand Down
12 changes: 11 additions & 1 deletion aio/tools/examples/shared/boilerplate/ivy/cli/src/tsconfig.app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,17 @@
},
"exclude": [
"test.ts",
"**/*.spec.ts"
"**/*.spec.ts",
"**/*.avoid.ts",
"**/*.0.ts",
"**/*.1.ts",
"**/*.1b.ts",
"**/*.2.ts",
"**/*.3.ts",
"**/*.4.ts",
"**/*.5.ts",
"**/*.6.ts",
"**/*.7.ts"
],
"angularCompilerOptions": {
"enableIvy": "ngtsc",
Expand Down