Skip to content

fix(docs-infra): add progression files to exclude list for docs examples - #28650

Closed
brandonroberts wants to merge 1 commit into
angular:masterfrom
brandonroberts:fix-examples-ivy
Closed

brandonroberts wants to merge 1 commit into
angular:masterfrom
brandonroberts:fix-examples-ivy

Conversation

@brandonroberts

Copy link
Copy Markdown
Contributor

Also disables Http guide under Ivy tests with documented error

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Also disables Http guide under Ivy tests with documented error
@brandonroberts
brandonroberts requested a review from a team February 11, 2019 20:42
@mary-poppins

Copy link
Copy Markdown

You can preview 21e8161 at https://pr28650-21e8161.ngbuilds.io/.

@ngbot ngbot Bot added this to the Backlog milestone Feb 11, 2019
@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Feb 11, 2019
@mhevery mhevery closed this in 1e64f37 Feb 11, 2019
gkalpak pushed a commit to gkalpak/angular that referenced this pull request Feb 13, 2019
…les (angular#28650)

Also disables Http guide under Ivy tests with documented error

PR Close angular#28650
gkalpak pushed a commit to gkalpak/angular that referenced this pull request Feb 14, 2019
…les (angular#28650)

Also disables Http guide under Ivy tests with documented error

PR Close angular#28650
mhevery pushed a commit that referenced this pull request Feb 14, 2019
* ci(docs-infra): run docs examples tests in production mode (#28592)

PR Close #28592

* docs: remove quickstart example and copy tsconfig.1.json into TS config guide (#28592)

This example has long been replaced by the cli-quickstart, but was never deleted.

PR Close #28592

* docs: enable E2E test for setup example (#28592)

This guide is not being shown publicly, and its test is currently being ignored.
Instead of deleting this test and guide, it may be repurposed in the future for a local development guide.

PR Close #28592

* docs: ignore progression filenames from compilation (#28592)

PR Close #28592

* docs: remove unused StringSafeDatePipe from AngularJS Quick Ref example (#28592)

PR Close #28592

* docs: make parent finder functions compatible with AoT (#28592)

PR Close #28592

* docs: make toggleImage arguments optional in AngularJS quick reference (#28592)

PR Close #28592

* docs: add insert remove component to AppModule for animations example (#28592)

PR Close #28592

* docs: ignore component for app compilation for displaying data example (#28592)

PR Close #28592

* docs: ignore files from app compilation for ngmodule-faq example (#28592)

PR Close #28592

* docs: ignore initial components for app compilation in router example (#28592)

PR Close #28592

* docs: remove unused files in styleguide example (#28592)

PR Close #28592

* docs: make method arguments optional in template syntax example (#28592)

PR Close #28592

* docs: add more files to be ignored during app compilation (#28592)

PR Close #28592

* docs: run component-interaction and DI in JiT mode (#28592)

PR Close #28592

* docs: re-enable E2E tests for Http guide (#28592)

PR Close #28592

* ci(docs-infra): test docs examples with Ivy (#28463)

PR Close #28463

* fix(docs-infra): add progression files to exclude list for docs examples (#28650)

Also disables Http guide under Ivy tests with documented error

PR Close #28650

* fix(docs-infra): fix filtering in run-example-e2e.js (#28663)

PR Close #28663

* test(ivy): enable more docs examples e2e tests (#28688)

PR Close #28688
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours risk: low target: major This PR is targeted for the next major release type: bug/fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants