docs: add missing guides, examples, images to CODEOWNERS by gkalpak · Pull Request #28597 · angular/angular

gkalpak · 2019-02-07T16:22:05Z

Some guides/examples/images from aio/content/ did not have owners (in .github/CODEOWNERS) and fell back to the default owners.
This PR adds owners for all guides/examples/images.

gkalpak · 2019-02-07T16:23:27Z

cc @IgorMinar

cheatsheet should go under core.

glossary and public api should go into the public_api group at the bottom

I assume you meant "glossary and styleguide" 😃

I think of glossary and architecture docs as part of docs-intro, similar to getting started and tutorial. I suppose glossary could be public-api, but architecture is definitely similar to other intro materials.

I think that all three of these should go under public api as they are the most visible terminology definitions, recommendations and "style" guides.

gkalpak · 2019-02-07T16:23:37Z

cc @IgorMinar

let's move all of these into the docs-infra group

IgorMinar

responding to questions...

IgorMinar · 2019-02-08T06:28:09Z

cheatsheet should go under core.

glossary and public api should go into the public_api group at the bottom

IgorMinar · 2019-02-08T06:29:49Z

let's move all of these into the docs-infra group

gkalpak · 2019-02-12T08:09:52Z

@IgorMinar, what about these ones?

It would be good to have a codeowners group(s) that alexE and hans can approve, for libraries, schematics, CLI overview page.

libraries should likely be a separate category with a separate team owning it - the owners should be some folks on the tooling team and me. @alexeagle can give you the list of tooling team ppl

and yesk, I previously said that we should reuse ngtools group, but now I'm thinking that reviewing library docs changes requires a very specific knowledge, so a custom group would be better.

Hmm, I think it's probably @hansl, @mgechev, @alan-agius4

gkalpak · 2019-02-12T10:07:10Z

(Note: The CI failure in test_ivy_aot is inherited from master and that job's outcome is not affected by this PR.)

IgorMinar

the rest looks good.

please resolve comments and remove all TODOs and ??? and send for merge.

IgorMinar · 2019-02-28T09:06:53Z

I think that all three of these should go under public api as they are the most visible terminology definitions, recommendations and "style" guides.

IgorMinar · 2019-02-28T09:09:40Z

libraries should likely be a separate category with a separate team owning it - the owners should be some folks on the tooling team and me. @alexeagle can give you the list of tooling team ppl

gkalpak · 2019-02-28T17:11:49Z

I made all necessary changes. @IgorMinar, you need to create the fw-docs-libraries GitHub group.

gkalpak · 2019-03-07T20:19:24Z

I found out I can create the GitHub team myself, so I created tools-docs-libraries.

gkalpak · 2019-03-07T20:40:08Z

merge-assistance: @IgorMinar said I can send for merge (#28597 (review)).

kara · 2019-03-07T21:09:42Z

Note: The changes aren't applying cleanly to patch, so merging it into master now, and George has agreed to create another PR against the patch branch that resolves the conflicts.

… have owners It is useful for manually checking that all guides/examples/images have owners in `.github/CODEOWNERS`, but is not used for automatic verification (e.g. on CI) for now.

PR Close #28597

… have owners (#28597) It is useful for manually checking that all guides/examples/images have owners in `.github/CODEOWNERS`, but is not used for automatic verification (e.g. on CI) for now. PR Close #28597

PR Close angular#28597

… have owners (angular#28597) It is useful for manually checking that all guides/examples/images have owners in `.github/CODEOWNERS`, but is not used for automatic verification (e.g. on CI) for now. PR Close angular#28597

angular-automatic-lock-bot · 2019-09-14T19:23:13Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

gkalpak requested a review from IgorMinar as a code owner February 7, 2019 16:22

gkalpak requested review from a team February 7, 2019 16:22

googlebot added the cla: yes label Feb 7, 2019

gkalpak added the comp: docs label Feb 7, 2019

ngbot Bot added this to the needsTriage milestone Feb 7, 2019

gkalpak added action: review The PR is still awaiting reviews from at least one requested reviewer comp: docs-infra target: patch This PR is targeted for the next patch release labels Feb 7, 2019

gkalpak assigned IgorMinar Feb 7, 2019

gkalpak commented Feb 7, 2019

View reviewed changes

IgorMinar reviewed Feb 8, 2019

View reviewed changes

IgorMinar added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 8, 2019

gkalpak force-pushed the docs-update-codeowners branch from 7027a02 to 1853700 Compare February 12, 2019 07:57

gkalpak commented Feb 12, 2019

View reviewed changes

gkalpak added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 12, 2019

gkalpak mentioned this pull request Feb 27, 2019

docs: update ivy opt-in flag #29010

Closed

3 of 14 tasks

IgorMinar approved these changes Feb 28, 2019

View reviewed changes

gkalpak force-pushed the docs-update-codeowners branch 3 times, most recently from caea04a to cb61558 Compare February 28, 2019 17:09

gkalpak force-pushed the docs-update-codeowners branch from cb61558 to 3fe3661 Compare March 7, 2019 20:15

gkalpak added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Mar 7, 2019

gkalpak removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 7, 2019

kara added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Mar 7, 2019

gkalpak added 3 commits March 7, 2019 13:12

docs: add missing guides, examples, images to CODEOWNERS

411151d

docs: remove unused examples and images

b09a145

test(docs-infra): add script for verifying all guides/examples/images…

652b911

… have owners It is useful for manually checking that all guides/examples/images have owners in `.github/CODEOWNERS`, but is not used for automatic verification (e.g. on CI) for now.

kara force-pushed the docs-update-codeowners branch from 3fe3661 to 652b911 Compare March 7, 2019 21:14

kara closed this in 4f2773e Mar 7, 2019

kara pushed a commit that referenced this pull request Mar 7, 2019

docs: remove unused examples and images (#28597)

ad9415a

PR Close #28597

gkalpak deleted the docs-update-codeowners branch March 7, 2019 21:26

gkalpak mentioned this pull request Mar 7, 2019

docs: add missing guides, examples, images to CODEOWNERS #29172

Closed

sreevani-ship-it mentioned this pull request Apr 8, 2019

HttpUrlEncodingCodec lacks detail #27870

Closed

wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019

docs: add missing guides, examples, images to CODEOWNERS (angular#28597)

f599e30

PR Close angular#28597

wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019

docs: remove unused examples and images (angular#28597)

8277529

PR Close angular#28597

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019

Conversation

gkalpak commented Feb 7, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

IgorMinar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gkalpak commented Feb 12, 2019

Uh oh!

IgorMinar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gkalpak commented Feb 28, 2019

Uh oh!

gkalpak commented Mar 7, 2019

Uh oh!

gkalpak commented Mar 7, 2019

Uh oh!

kara commented Mar 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

angular-automatic-lock-bot Bot commented Sep 14, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

kara commented Mar 7, 2019 •

edited

Loading