Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
883d6e4
ci(docs-infra): run docs examples tests in production mode
brandonroberts Feb 7, 2019
a24a121
docs: remove quickstart example and copy tsconfig.1.json into TS conf…
brandonroberts Feb 7, 2019
56001ae
docs: enable E2E test for setup example
brandonroberts Feb 7, 2019
e0190d7
docs: ignore progression filenames from compilation
brandonroberts Feb 7, 2019
ad78ae1
docs: remove unused StringSafeDatePipe from AngularJS Quick Ref example
brandonroberts Feb 7, 2019
4daf206
docs: make parent finder functions compatible with AoT
brandonroberts Feb 7, 2019
2159be3
docs: make toggleImage arguments optional in AngularJS quick reference
brandonroberts Feb 7, 2019
e0889cc
docs: add insert remove component to AppModule for animations example
brandonroberts Feb 7, 2019
e81f922
docs: ignore component for app compilation for displaying data example
brandonroberts Feb 7, 2019
fd99cf1
docs: make method arguments optional for event-binding example
brandonroberts Feb 7, 2019
c99a74d
docs: ignore files from app compilation for ngmodule-faq example
brandonroberts Feb 7, 2019
ded0841
docs: ignore initial components for app compilation in router example
brandonroberts Feb 7, 2019
d791ef6
docs: remove unused files in styleguide example
brandonroberts Feb 7, 2019
14ac2be
docs: make method arguments optional in template syntax example
brandonroberts Feb 7, 2019
3d3e3fe
docs: add more files to be ignored during app compilation
brandonroberts Feb 7, 2019
beff21f
docs: run component-interaction and DI in JiT mode
brandonroberts Feb 7, 2019
b42a1a9
docs: re-enable E2E tests for Http guide
brandonroberts Feb 7, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export class AppComponent {
movies: IMovie[] = [];
showImage = true;
title = 'AngularJS to Angular Quick Ref Cookbook';
toggleImage(event: UIEvent) {
toggleImage(event?: UIEvent) {
this.showImage = !this.showImage;
this.eventType = (event && event.type) || 'not provided';
}
Expand Down
14 changes: 0 additions & 14 deletions aio/content/examples/ajs-quick-reference/src/app/date.pipe.ts

This file was deleted.

2 changes: 2 additions & 0 deletions aio/content/examples/animations/src/app/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import { HeroListAutoCalcPageComponent } from './hero-list-auto-page.component';
import { HeroListAutoComponent } from './hero-list-auto.component';
import { HomeComponent } from './home.component';
import { AboutComponent } from './about.component';
import { InsertRemoveComponent } from './insert-remove.component';


@NgModule({
Expand Down Expand Up @@ -56,6 +57,7 @@ import { AboutComponent } from './about.component';
HeroListAutoCalcPageComponent,
HeroListAutoComponent,
HomeComponent,
InsertRemoveComponent,
AboutComponent
],
bootstrap: [AppComponent]
Expand Down
11 changes: 11 additions & 0 deletions aio/content/examples/component-interaction/example-config.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"e2e": [
{
"cmd": "yarn",
"args": [
"e2e",
"--no-webdriver-update"
]
}
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -19,20 +19,20 @@ const DifferentParent = Parent;
// #enddocregion provide-the-parent
// The `parentType` defaults to `Parent` when omitting the second parameter.
// #docregion provide-the-parent
const provideParent =
export function provideParent
// #enddocregion provide-parent, provide-the-parent
// #docregion provide-parent
(component: any, parentType?: any) => {
(component: any, parentType?: any) {
return { provide: parentType || Parent, useExisting: forwardRef(() => component) };
};
}
// #enddocregion provide-parent

// Simpler syntax version that always provides the component in the name of `Parent`.
const provideTheParent =
export function provideTheParent
// #docregion provide-the-parent
(component: any) => {
(component: any) {
return { provide: Parent, useExisting: forwardRef(() => component) };
};
}
// #enddocregion provide-the-parent


Expand Down
11 changes: 11 additions & 0 deletions aio/content/examples/dependency-injection/example-config.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"e2e": [
{
"cmd": "yarn",
"args": [
"e2e",
"--no-webdriver-update"
]
}
]
}
4 changes: 2 additions & 2 deletions aio/content/examples/event-binding/src/app/app.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export class AppComponent {
currentItem = { name: 'teapot'} ;
clickMessage = '';

onSave(event: KeyboardEvent) {
onSave(event?: KeyboardEvent) {
const evtMsg = event ? ' Event target is ' + (<HTMLElement>event.target).textContent : '';
alert('Saved.' + evtMsg);
if (event) { event.stopPropagation(); }
Expand All @@ -21,7 +21,7 @@ export class AppComponent {
alert(`Delete the ${item}.`);
}

onClickMe(event: KeyboardEvent) {
onClickMe(event?: KeyboardEvent) {
const evtMsg = event ? ' Event target class is ' + (<HTMLElement>event.target).className : '';
alert('Click me.' + evtMsg);
}
Expand Down
5 changes: 1 addition & 4 deletions aio/content/examples/http/e2e/src/app.e2e-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,7 @@ let checkLogForMessage = (message: string) => {
expect(page.logList.getText()).toContain(message);
};

// TODO(i): temorarily disable these tests because angular-in-memory-web-api is not compatible with rxjs v6 yet
// and we don't have the backwards compatibility package yet.
// Reenable after rxjs v6 compatibility package is out or angular-in-memory-web-api is compatible with rxjs v6

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for cleaning this up!

xdescribe('Http Tests', function() {
describe('Http Tests', function() {
beforeEach(() => {
browser.get('');
});
Expand Down
13 changes: 11 additions & 2 deletions aio/content/examples/i18n/example-config.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
{
"projectType": "i18n"
}
"projectType": "i18n",
"e2e": [
{
"cmd": "yarn",
"args": [
"e2e",
"--no-webdriver-update"
]
}
]
}
4 changes: 2 additions & 2 deletions aio/content/examples/ngmodule-faq/src/app/app.module.3.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ import { AppComponent } from './app.component';
// #enddocregion
*/
// #docregion
import { HighlightDirective } from './highlight.directive';
import { TitleComponent } from './title.component';
import { HighlightDirective } from './highlight.directive.1';
import { TitleComponent } from './title.component.1';
import { UserService } from './user.service';

/* Routing Module */
Expand Down
10 changes: 0 additions & 10 deletions aio/content/examples/ngmodule-faq/src/app/contact/awesome.pipe.ts

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { UserService } from './user.service';

@Component({
selector: 'app-title',
templateUrl: './title.component.html'
templateUrl: './title.component.1.html'
})
export class TitleComponent {
title = 'Angular Modules';
Expand Down
8 changes: 0 additions & 8 deletions aio/content/examples/quickstart/bs-config.1.json

This file was deleted.

8 changes: 0 additions & 8 deletions aio/content/examples/quickstart/src/app/app.component.ts

This file was deleted.

11 changes: 0 additions & 11 deletions aio/content/examples/quickstart/src/app/app.module.ts

This file was deleted.

31 changes: 0 additions & 31 deletions aio/content/examples/quickstart/src/index.html

This file was deleted.

5 changes: 0 additions & 5 deletions aio/content/examples/quickstart/src/main.ts

This file was deleted.

13 changes: 0 additions & 13 deletions aio/content/examples/quickstart/src/tsconfig.1.json

This file was deleted.

11 changes: 0 additions & 11 deletions aio/content/examples/quickstart/stackblitz.json

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { Component } from '@angular/core';

@Component({
selector: 'app-crisis-list',
templateUrl: './crisis-list.component.html',
styleUrls: ['./crisis-list.component.css']
templateUrl: './crisis-list.component.1.html',
styleUrls: ['./crisis-list.component.1.css']
})
export class CrisisListComponent { }
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { Component } from '@angular/core';

@Component({
selector: 'app-hero-list',
templateUrl: './hero-list.component.html',
styleUrls: ['./hero-list.component.css']
templateUrl: './hero-list.component.1.html',
styleUrls: ['./hero-list.component.1.css']
})
export class HeroListComponent { }
Empty file.
17 changes: 0 additions & 17 deletions aio/content/examples/setup/e2e-spec.ts

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// #docregion
export * from './spinner.component';
export * from './spinner.service';

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// #docregion
export * from './toast.component';
export * from './toast.service';

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,7 @@ import { Component } from '@angular/core';
selector: 'sg-app',
templateUrl: './app.component.html'
})
export class AppComponent { }
export class AppComponent {

doSomething() {}
}
Loading