Skip to content

ci(docs-infra): run docs examples E2E tests in production mode - #28592

Closed
brandonroberts wants to merge 17 commits into
angular:masterfrom
brandonroberts:docs-examples-prod
Closed

brandonroberts wants to merge 17 commits into
angular:masterfrom
brandonroberts:docs-examples-prod

Conversation

@brandonroberts

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Updated E2E test suites for docs examples to be run in production mode to ensure the example code works with AoT. Also runs all tests that are available.

@brandonroberts brandonroberts added feature Label used to distinguish feature request from other issues comp: docs effort1: hours risk: low labels Feb 7, 2019
@brandonroberts
brandonroberts requested review from a team February 7, 2019 13:34
@ngbot ngbot Bot added this to the Backlog milestone Feb 7, 2019
@mary-poppins

Copy link
Copy Markdown

You can preview 883d6e4 at https://pr28592-883d6e4.ngbuilds.io/.

@brandonroberts brandonroberts added the target: patch This PR is targeted for the next patch release label Feb 7, 2019
…ig guide

This example has long been replaced by the cli-quickstart, but was never deleted.
This guide is not being shown publicly, and its test is currently being ignored.
Instead of deleting this test and guide, it may be repurposed in the future for a local development guide.
@brandonroberts
brandonroberts requested review from a team February 7, 2019 14:58
@brandonroberts
brandonroberts requested a review from a team February 7, 2019 17:38
gkalpak pushed a commit to gkalpak/angular that referenced this pull request Feb 13, 2019
gkalpak pushed a commit to gkalpak/angular that referenced this pull request Feb 13, 2019
…ig guide (angular#28592)

This example has long been replaced by the cli-quickstart, but was never deleted.

PR Close angular#28592
gkalpak pushed a commit to gkalpak/angular that referenced this pull request Feb 13, 2019
This guide is not being shown publicly, and its test is currently being ignored.
Instead of deleting this test and guide, it may be repurposed in the future for a local development guide.

PR Close angular#28592
gkalpak pushed a commit to gkalpak/angular that referenced this pull request Feb 13, 2019
gkalpak pushed a commit to gkalpak/angular that referenced this pull request Feb 13, 2019
gkalpak pushed a commit to gkalpak/angular that referenced this pull request Feb 13, 2019
gkalpak pushed a commit to gkalpak/angular that referenced this pull request Feb 13, 2019
gkalpak pushed a commit to gkalpak/angular that referenced this pull request Feb 13, 2019
gkalpak pushed a commit to gkalpak/angular that referenced this pull request Feb 13, 2019
gkalpak pushed a commit to gkalpak/angular that referenced this pull request Feb 13, 2019
gkalpak pushed a commit to gkalpak/angular that referenced this pull request Feb 13, 2019
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours feature Label used to distinguish feature request from other issues merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note risk: low target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants