Skip to content

build: switch to typescript's es2015 typings#28570

Closed
alexeagle wants to merge 1 commit into
angular:masterfrom
alexeagle:typings
Closed

build: switch to typescript's es2015 typings#28570
alexeagle wants to merge 1 commit into
angular:masterfrom
alexeagle:typings

Conversation

@alexeagle

Copy link
Copy Markdown
Contributor

Note that this allows Angular to depend on the entirety of the ES2015 API, not just our restricted subset.
This change is needed because our copy of the subset was out-of-date, and prevents us using ES2015 target in dev mode.

This is a subset of #27738

This commit was reverted yesterday because it depended on a g3 change which had been rolled back. That change is now rolled forward and seems to stick.

Note that this allows Angular to depend on the entirety of the ES2015 API, not just our restricted subset.
This change is needed because our copy of the subset was out-of-date, and prevents us using ES2015 target in dev mode.

This is a subset of angular#27738
@alexeagle alexeagle requested a review from IgorMinar February 6, 2019 18:05
@alexeagle alexeagle added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: build & ci Related the build and CI infrastructure of the project labels Feb 6, 2019
@ngbot ngbot Bot added this to the needsTriage milestone Feb 6, 2019
@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 6, 2019
@matsko

matsko commented Feb 6, 2019

Copy link
Copy Markdown
Contributor

matsko pushed a commit that referenced this pull request Feb 6, 2019
Note that this allows Angular to depend on the entirety of the ES2015 API, not just our restricted subset.
This change is needed because our copy of the subset was out-of-date, and prevents us using ES2015 target in dev mode.

This is a subset of #27738

PR Close #28570
@matsko matsko closed this in 6709db9 Feb 6, 2019
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants