docs: add ivy opt-in docs by filipesilva · Pull Request #28569 · angular/angular

filipesilva · 2019-02-06T17:18:58Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the new behavior?

Adds a Ivy opt-in instructions.

Does this PR introduce a breaking change?

Yes
No

Other information

filipesilva · 2019-02-06T17:19:59Z

What is the best place to add this page in?

not sure. @jenniferfell can you please propose some place?

This doc should be placed in the aio/content/guide directory. I think it would be good also to rename the doc to something like ivy-preview if this is going to be temporary.

Renamed and added under the Techniques section of navigation as Ivy Preview. @StephenFluin @jenniferfell can you confirm this location is the appropriate one?

mary-poppins · 2019-02-06T17:23:35Z

You can preview 0982573 at https://pr28569-0982573.ngbuilds.io/.

IgorMinar

great start!

Let's wait for the blog post to land and experimentalIvy boolean flag to land and then merge this PR

IgorMinar · 2019-02-08T06:37:18Z

not sure. @jenniferfell can you please propose some place?

filipesilva · 2019-02-08T12:09:50Z

Blocked on #28616.

mary-poppins · 2019-02-13T15:30:21Z

You can preview 58af057 at https://pr28569-58af057.ngbuilds.io/.

alan-agius4 · 2019-02-14T13:41:04Z

@filipesilva, this is really good!

Should we mentioned the limitation that if one has multiple projects within the workspace, all of them will need to be build using Ivy? As users will have cryptic error messages on projects that rely on ngc but ngcc was run.

At least until ngcc is around and not part of the build pipeline.

Added a note about that:

Until that happens, opting into Ivy means that all projects in a single CLI workspace will be compiled with Ivy.

filipesilva · 2019-02-20T12:55:44Z

@jenniferfell can you review and advise on where the best place to link this page in is please?

mary-poppins · 2019-02-20T12:59:59Z

You can preview a743c6d at https://pr28569-a743c6d.ngbuilds.io/.

gkalpak · 2019-02-21T15:20:46Z

Isn't "allowEmptyCodegenFiles": true required any more?

Yes, it is still required right now. But #28685 (or a similar approach) will make it not needed.

Added it here for now, to remove later when the other PR is in.

mary-poppins · 2019-02-21T16:53:53Z

You can preview e6b7e28 at https://pr28569-e6b7e28.ngbuilds.io/.

googlebot · 2019-02-25T12:59:17Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

mary-poppins · 2019-02-25T13:03:26Z

You can preview 85158bb at https://pr28569-85158bb.ngbuilds.io/.

mary-poppins · 2019-02-25T13:03:58Z

You can preview baa0444 at https://pr28569-baa0444.ngbuilds.io/.

googlebot · 2019-02-25T13:04:16Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

mary-poppins · 2019-02-25T13:05:09Z

You can preview 6a57d06 at https://pr28569-6a57d06.ngbuilds.io/.

mary-poppins · 2019-02-25T13:05:15Z

You can preview 7cdd898 at https://pr28569-7cdd898.ngbuilds.io/.

mary-poppins · 2019-02-25T13:05:44Z

You can preview 16b9b39 at https://pr28569-16b9b39.ngbuilds.io/.

mary-poppins · 2019-02-25T13:07:28Z

You can preview 3a91668 at https://pr28569-3a91668.ngbuilds.io/.

mary-poppins · 2019-02-25T17:03:52Z

You can preview e6211d6 at https://pr28569-e6211d6.ngbuilds.io/.

filipesilva · 2019-02-26T10:16:48Z

To summarize, this PR is ready to merge but there are still open action items that should be addressed and whose changes are to be fed back into this document:

consolidate flags (--experimental-ivy vs --enable-ivy): docs: add ivy opt-in docs #28569 (comment)
- AI for @filipesilva to do on CLI repo (feat(@schematics/angular): rename experimentalIvy to enableIvy angular-cli#13773)
human readable name to replace allowEmptyCodegenFiles : docs: add ivy opt-in docs #28569 (comment)
- AI for @kara @alxhub to comment on, TBD implementer
ivy-ngcc binary name: docs: add ivy opt-in docs #28569 (comment)
- AI for @petebacondarwin @gkalpak @kara @alxhub to comment on, TBD implementer

benb7760 · 2019-02-26T10:30:19Z

remove 'and' from this sentence?

Hey thanks for taking a look! Yes that shouldn't be there, removed now.

mary-poppins · 2019-02-26T10:49:53Z

You can preview c030eeb at https://pr28569-c030eeb.ngbuilds.io/.

Followup to angular/angular#28569 (comment)

petebacondarwin · 2019-02-26T12:35:14Z

Opting is a word - no hyphen needed

I changed mentions of opt-ing to opting but left mentions of opt-in as is.

mary-poppins · 2019-02-26T14:11:57Z

You can preview a907c80 at https://pr28569-a907c80.ngbuilds.io/.

Followup to angular/angular#28569 (comment)

Followup to #28569 (comment) and angular/angular-cli#13773. Note: this flag will only work on `@angular/cli@8.0.0-beta.3` (currently unreleased) and above. PR Close #29010

angular-automatic-lock-bot · 2019-09-14T18:51:56Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

filipesilva added the state: WIP label Feb 6, 2019

filipesilva requested a review from IgorMinar as a code owner February 6, 2019 17:18

googlebot added the cla: yes label Feb 6, 2019

filipesilva commented Feb 6, 2019

View reviewed changes

Comment thread aio/content/cli/ivy.md Resolved

filipesilva commented Feb 6, 2019

View reviewed changes

Comment thread aio/content/cli/ivy.md Resolved

filipesilva requested a review from jenniferfell February 6, 2019 17:22

cexbrayat reviewed Feb 7, 2019

View reviewed changes

Comment thread aio/content/cli/ivy.md Resolved

IgorMinar approved these changes Feb 8, 2019

View reviewed changes

IgorMinar added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews state: blocked labels Feb 8, 2019

mhevery added the comp: docs label Feb 8, 2019

ngbot Bot added this to the needsTriage milestone Feb 8, 2019

wKoza mentioned this pull request Feb 11, 2019

[ivy] ng new ivy4ever --experimentalIvy=true doesn't add aot: true option angular/angular-cli#13646

Closed

alexeagle added the target: major This PR is targeted for the next major release label Feb 12, 2019

alan-agius4 reviewed Feb 14, 2019

View reviewed changes

filipesilva added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: blocked state: WIP action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 20, 2019

gkalpak mentioned this pull request Feb 20, 2019

[ivy] lazy loaded modules can not be found / imported #28866

Closed

gkalpak reviewed Feb 21, 2019

View reviewed changes

brandonroberts self-assigned this Feb 21, 2019

brandonroberts added the aio: preview label Feb 21, 2019

googlebot added cla: no and removed cla: yes labels Feb 25, 2019

googlebot added cla: yes and removed cla: no labels Feb 25, 2019

filipesilva removed action: review The PR is still awaiting reviews from at least one requested reviewer action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 26, 2019

benb7760 reviewed Feb 26, 2019

View reviewed changes

filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Feb 26, 2019

feat(@schematics/angular): rename experimentalIvy to enableIvy

d6e525b

Followup to angular/angular#28569 (comment)

filipesilva mentioned this pull request Feb 26, 2019

feat(@schematics/angular): rename experimentalIvy to enableIvy angular/angular-cli#13773

Merged

petebacondarwin reviewed Feb 26, 2019

View reviewed changes

docs: add ivy opt-in docs

a907c80

benlesh closed this in f01247f Feb 26, 2019

mgechev pushed a commit to angular/angular-cli that referenced this pull request Feb 26, 2019

feat(@schematics/angular): rename experimentalIvy to enableIvy

0596664

Followup to angular/angular#28569 (comment)

filipesilva mentioned this pull request Feb 27, 2019

docs: update ivy opt-in flag #29010

Closed

3 of 14 tasks

filipesilva deleted the docs-ivy-optin branch February 28, 2019 10:07

AndrewKushnir pushed a commit that referenced this pull request Mar 6, 2019

docs: update ivy opt-in flag (#29010)

6b98b53

Followup to #28569 (comment) and angular/angular-cli#13773. Note: this flag will only work on `@angular/cli@8.0.0-beta.3` (currently unreleased) and above. PR Close #29010

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019

Conversation

filipesilva commented Feb 6, 2019

PR Checklist

PR Type

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mary-poppins commented Feb 6, 2019

Uh oh!

Uh oh!

IgorMinar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

filipesilva commented Feb 8, 2019

Uh oh!

mary-poppins commented Feb 13, 2019

Uh oh!

alan-agius4 Feb 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

filipesilva commented Feb 20, 2019

Uh oh!

mary-poppins commented Feb 20, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mary-poppins commented Feb 21, 2019

Uh oh!

googlebot commented Feb 25, 2019

Uh oh!

mary-poppins commented Feb 25, 2019

Uh oh!

mary-poppins commented Feb 25, 2019

Uh oh!

googlebot commented Feb 25, 2019

Uh oh!

mary-poppins commented Feb 25, 2019

Uh oh!

mary-poppins commented Feb 25, 2019

Uh oh!

mary-poppins commented Feb 25, 2019

Uh oh!

mary-poppins commented Feb 25, 2019

Uh oh!

mary-poppins commented Feb 25, 2019

Uh oh!

filipesilva commented Feb 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mary-poppins commented Feb 26, 2019

Uh oh!

Choose a reason for hiding this comment

alan-agius4 Feb 14, 2019 •

edited

Loading

filipesilva commented Feb 26, 2019 •

edited

Loading