Skip to content

feat(ivy): support listing lazy routes for specific entry point - #28526

Closed
gkalpak wants to merge 4 commits into
angular:masterfrom
gkalpak:feat-ivy-list-partial-lazy-routes
Closed

feat(ivy): support listing lazy routes for specific entry point#28526
gkalpak wants to merge 4 commits into
angular:masterfrom
gkalpak:feat-ivy-list-partial-lazy-routes

Conversation

@gkalpak

@gkalpak gkalpak commented Feb 4, 2019

Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@gkalpak
gkalpak requested a review from IgorMinar as a code owner February 4, 2019 21:23
@gkalpak
gkalpak requested a review from a team February 4, 2019 21:23
@gkalpak gkalpak added feature Label used to distinguish feature request from other issues state: WIP target: major This PR is targeted for the next major release comp: ivy labels Feb 4, 2019
@ngbot ngbot Bot modified the milestone: needsTriage Feb 4, 2019
@gkalpak
docs: re-phrase note in architecture guide for clarity
c8507a6
@gkalpak
refactor(ivy): remove unnecessary method from ngtsc's RouterEntryPoint
d05168e
@gkalpak
refactor(ivy): create lazy route keys that are similar to ngtools laz…
aa8f538 
…y routes

This will make it easier to retrieve routes for specific entry points in
`listLazyRoutes()` (which is necessary for CLI integration but not yet
implemented).
@gkalpak
feat(ivy): implement listing lazy routes for specific entry point in …
6fe3a31 
…`ngtsc`

Related: angular/angular-cli#13532

Jira issue: FW-860
@gkalpak
gkalpak force-pushed the feat-ivy-list-partial-lazy-routes branch from 259a918 to 6fe3a31 Compare February 5, 2019 14:53
@gkalpak gkalpak closed this Feb 5, 2019
@gkalpak

gkalpak commented Feb 7, 2019

Copy link
Copy Markdown
Member Author

Superceded by #28542.

@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 14, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@IgorMinar IgorMinar Awaiting requested review from IgorMinar

Assignees

No one assigned

Labels

cla: yes feature Label used to distinguish feature request from other issues state: WIP target: major This PR is targeted for the next major release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

2 participants

@gkalpak @googlebot