Repository navigation
fix(ivy): sanitize external i18n ids before generating const names - #28522
Closed
AndrewKushnir wants to merge 2 commits into
Closed
AndrewKushnir wants to merge 2 commits into
AndrewKushnir wants to merge 2 commits into
Conversation
AndrewKushnir
added
type: bug/fix
action: review
ocombe
approved these changes
Feb 5, 2019
Prior to this change there was no i18n id sanitization before we output goog.getMsg calls. Due to the fact that message ids are used as a part of const names, some characters were bcausing issues while executing generated code. This commit adds sanitization to i18n ids used to generate i18n-related consts.
AndrewKushnir
force-pushed
the
i18n_const_name_sanitization
branch
from
February 5, 2019 20:27
b1d956c to
9d73260
Compare
Contributor
Author
alxhub
approved these changes
Feb 5, 2019
AndrewKushnir
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change there was no i18n id sanitization before we output
goog.getMsgcalls. Due to the fact that message ids are used as a part of const names, some characters were causing issues while executing generated code. This commit adds sanitization to i18n ids used to generate i18n-related consts.PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?