Repository navigation
Conversation
gkalpak
added
type: bug/fix
area: build & ci
gkalpak
force-pushed
the
ci-repin-ChromeDriver
branch
from
February 1, 2019 22:27
c77b6e6 to
04a9e31
Compare
gkalpak
force-pushed
the
ci-repin-ChromeDriver
branch
3 times, most recently
from
February 1, 2019 23:07
a9e46d0 to
de88fcc
Compare
gkalpak
added
state: WIP
and removed
action: review
gkalpak
force-pushed
the
ci-repin-ChromeDriver
branch
from
February 1, 2019 23:59
8c1754c to
b787f64
Compare
By default, `webdriver-manager update` will download the latest ChromeDriver version, which might not be compatible with the Chrome version included in the [docker image used on CI], causing CI failures. Previously, we used to pin the ChromeDriver version on CI in [ngcontainer's Dockerfile][2]. This was accidentally broken in angular#26691, while moving from ngcontainer to default CircleCI docker images. This commit fixes the issue by pinning ChromeDriver to a known compatible version. [1]: https://github.com/angular/angular/blob/bfd48d156d5663cc49d1ec40c2d73ff76a2fe62f/.circleci/config.yml#L16 [2]: https://github.com/angular/angular/blob/bfd48d156d5663cc49d1ec40c2d73ff76a2fe62f/tools/ngcontainer/Dockerfile#L63
gkalpak
force-pushed
the
ci-repin-ChromeDriver
branch
from
February 2, 2019 00:00
b787f64 to
f29b086
Compare
gkalpak
added
action: review
matsko
added
action: merge
alexeagle
approved these changes
Feb 2, 2019
alexeagle
left a comment
alexeagle
left a comment
Contributor
There was a problem hiding this comment.
nit: would have been a smaller change to continue naming it $CHROMEDRIVER_VERSION_ARG
ideally keep each PR to just changing one thing rather than add refactorings like --progress=false
kara
added
the
merge: caretaker note
matsko
pushed a commit
that referenced
this pull request
Feb 2, 2019
matsko
pushed a commit
that referenced
this pull request
Feb 2, 2019
matsko
pushed a commit
that referenced
this pull request
Feb 2, 2019
…me (#28494) By default, `webdriver-manager update` will download the latest ChromeDriver version, which might not be compatible with the Chrome version included in the [docker image used on CI], causing CI failures. Previously, we used to pin the ChromeDriver version on CI in [ngcontainer's Dockerfile][2]. This was accidentally broken in #26691, while moving from ngcontainer to default CircleCI docker images. This commit fixes the issue by pinning ChromeDriver to a known compatible version. [1]: https://github.com/angular/angular/blob/bfd48d156d5663cc49d1ec40c2d73ff76a2fe62f/.circleci/config.yml#L16 [2]: https://github.com/angular/angular/blob/bfd48d156d5663cc49d1ec40c2d73ff76a2fe62f/tools/ngcontainer/Dockerfile#L63 PR Close #28494
matsko
pushed a commit
that referenced
this pull request
Feb 2, 2019
matsko
pushed a commit
that referenced
this pull request
Feb 2, 2019
…me (#28494) By default, `webdriver-manager update` will download the latest ChromeDriver version, which might not be compatible with the Chrome version included in the [docker image used on CI], causing CI failures. Previously, we used to pin the ChromeDriver version on CI in [ngcontainer's Dockerfile][2]. This was accidentally broken in #26691, while moving from ngcontainer to default CircleCI docker images. This commit fixes the issue by pinning ChromeDriver to a known compatible version. [1]: https://github.com/angular/angular/blob/bfd48d156d5663cc49d1ec40c2d73ff76a2fe62f/.circleci/config.yml#L16 [2]: https://github.com/angular/angular/blob/bfd48d156d5663cc49d1ec40c2d73ff76a2fe62f/tools/ngcontainer/Dockerfile#L63 PR Close #28494
Contributor
|
In the CLI we ended up using |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Does this PR introduce a breaking change?
What is the current/new behavior?
By default,
webdriver-manager updatewill download the latest ChromeDriver version, which might not be compatible with the Chrome version included in the [docker image used on CI], causing CI failures.Previously, we used to pin the ChromeDriver version on CI in ngcontainer's Dockerfile. This was accidentally broken in #26691, while moving from ngcontainer to default CircleCI docker images.
This commit fixes the issue by pinning ChromeDriver to a known compatible version.