ci(docs-infra): build examples with Ivy by brandonroberts · Pull Request #28463 · angular/angular

brandonroberts · 2019-01-31T05:39:49Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

This builds and runs the E2E tests for the AIO examples using ivy.

Known Issues:

Examples using angular-in-memory-web-api won't build. Most likely due to non-APF. Should a mix be supported?

mary-poppins · 2019-01-31T05:44:31Z

You can preview 473dff2 at https://pr28463-473dff2.ngbuilds.io/.

mary-poppins · 2019-01-31T06:10:31Z

You can preview ed56d95 at https://pr28463-ed56d95.ngbuilds.io/.

mary-poppins · 2019-02-01T16:53:01Z

You can preview 9a72f1e at https://pr28463-9a72f1e.ngbuilds.io/.

brandonroberts · 2019-02-01T18:26:16Z

mary-poppins · 2019-02-01T20:41:13Z

You can preview f37351a at https://pr28463-f37351a.ngbuilds.io/.

mary-poppins · 2019-02-01T20:42:58Z

You can preview d43b0b2 at https://pr28463-d43b0b2.ngbuilds.io/.

mary-poppins · 2019-02-04T13:20:20Z

You can preview 4bdecd1 at https://pr28463-4bdecd1.ngbuilds.io/.

mary-poppins · 2019-02-04T15:34:32Z

You can preview 6e59f45 at https://pr28463-6e59f45.ngbuilds.io/.

mary-poppins · 2019-02-04T16:32:08Z

You can preview 0e89204 at https://pr28463-0e89204.ngbuilds.io/.

mary-poppins · 2019-02-04T18:05:11Z

You can preview 2378682 at https://pr28463-2378682.ngbuilds.io/.

brandonroberts · 2019-02-04T18:29:53Z

Remaining E2E failures as of https://circleci.com/gh/angular/angular/186135

Runtime failures:

/home/circleci/ng/aio/content/examples/ajs-quick-reference/ (movie list route not rendering)
/home/circleci/ng/aio/content/examples/component-interaction/ (version value goes undefined when clicking Major button after clicking Minor button twice)
/home/circleci/ng/aio/content/examples/component-styles/ (failed content projection and applied styles)
/home/circleci/ng/aio/content/examples/i18n/

app.component.html:3 ERROR Error: Unable to find context associated with [object HTMLButtonElement]
    at loadLContext (core.js:5480)
    at loadLContextFromNode (core.js:5539)
    at getListeners (core.js:5567)
    at DebugElement__POST_R3__.get [as listeners] (core.js:22279)
    at DebugRenderer2.push.../../../tools/examples/shared/node_modules/@angular/core/fesm5/core.js.DebugRenderer2.listen (core.js:25045)
    at listenToElementOutputs (core.js:23002)
    at createViewNodes (core.js:23913)
    at callViewAction (core.js:24262)
    at execComponentViewsAction (core.js:24181)
    at createViewNodes (core.js:23974)

Build failures:

/home/circleci/ng/aio/content/examples/dependency-injection/ (aot incompatible with useFactory and boolean in constructor) If no longer valid syntax, the DI guide will need to be updated also.

ocombe · 2019-02-05T15:49:00Z

You can't run i18n code with ivy until this is resolved: https://angular-team.atlassian.net/browse/FW-1026
We need to polyfill the runtime service for now.

mary-poppins · 2019-02-05T16:18:17Z

You can preview ea55d46 at https://pr28463-ea55d46.ngbuilds.io/.

mary-poppins · 2019-02-08T18:04:06Z

You can preview 98d3926 at https://pr28463-98d3926.ngbuilds.io/.

mary-poppins · 2019-02-08T18:05:14Z

You can preview 0739323 at https://pr28463-0739323.ngbuilds.io/.

mary-poppins · 2019-02-08T18:05:51Z

You can preview 0517871 at https://pr28463-0517871.ngbuilds.io/.

mary-poppins · 2019-02-08T18:31:20Z

You can preview f514575 at https://pr28463-f514575.ngbuilds.io/.

kara

LGTM

IgorMinar

thanks!

brandonroberts · 2019-02-11T14:31:03Z

Caretaker note: #28592 should land before this one as it may need a rebase.

gkalpak · 2019-02-12T08:03:20Z

            - test_docs_examples
-            # Get the artifacts to publish from the build-npm-packages job
+            - test_docs_examples_ivy
+            # Get the artifacts to publish from the build-packages-dist job


gkalpak · 2019-02-12T08:13:52Z

+    }
+
+    if (ivy) {
+      shelljs.exec(`yarn --cwd ${SHARED_PATH} ivy-ngcc`);


Oh, so this means that once you run examples with ivy, they will silently stay that way until you re-install node_modules/.
Let's hope people don't need to do this locally 😁

gkalpak · 2019-02-12T08:15:52Z

+
+  if (argv.ivy) {
+    log.push('');
+    log.push('Suites ignored due to breakage with Ivy:');


PR Close angular#28463

* ci(docs-infra): run docs examples tests in production mode (#28592) PR Close #28592 * docs: remove quickstart example and copy tsconfig.1.json into TS config guide (#28592) This example has long been replaced by the cli-quickstart, but was never deleted. PR Close #28592 * docs: enable E2E test for setup example (#28592) This guide is not being shown publicly, and its test is currently being ignored. Instead of deleting this test and guide, it may be repurposed in the future for a local development guide. PR Close #28592 * docs: ignore progression filenames from compilation (#28592) PR Close #28592 * docs: remove unused StringSafeDatePipe from AngularJS Quick Ref example (#28592) PR Close #28592 * docs: make parent finder functions compatible with AoT (#28592) PR Close #28592 * docs: make toggleImage arguments optional in AngularJS quick reference (#28592) PR Close #28592 * docs: add insert remove component to AppModule for animations example (#28592) PR Close #28592 * docs: ignore component for app compilation for displaying data example (#28592) PR Close #28592 * docs: ignore files from app compilation for ngmodule-faq example (#28592) PR Close #28592 * docs: ignore initial components for app compilation in router example (#28592) PR Close #28592 * docs: remove unused files in styleguide example (#28592) PR Close #28592 * docs: make method arguments optional in template syntax example (#28592) PR Close #28592 * docs: add more files to be ignored during app compilation (#28592) PR Close #28592 * docs: run component-interaction and DI in JiT mode (#28592) PR Close #28592 * docs: re-enable E2E tests for Http guide (#28592) PR Close #28592 * ci(docs-infra): test docs examples with Ivy (#28463) PR Close #28463 * fix(docs-infra): add progression files to exclude list for docs examples (#28650) Also disables Http guide under Ivy tests with documented error PR Close #28650 * fix(docs-infra): fix filtering in run-example-e2e.js (#28663) PR Close #28663 * test(ivy): enable more docs examples e2e tests (#28688) PR Close #28688

angular-automatic-lock-bot · 2019-09-14T18:21:39Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

brandonroberts added state: WIP comp: docs labels Jan 31, 2019

brandonroberts requested review from a team January 31, 2019 05:39

ngbot Bot added this to the needsTriage milestone Jan 31, 2019

googlebot added the cla: yes label Jan 31, 2019

brandonroberts force-pushed the docs-examples-ivy branch from 473dff2 to ed56d95 Compare January 31, 2019 06:05

brandonroberts force-pushed the docs-examples-ivy branch from ed56d95 to 9a72f1e Compare February 1, 2019 16:48

brandonroberts assigned IgorMinar Feb 1, 2019

brandonroberts requested a review from IgorMinar as a code owner February 1, 2019 20:36

brandonroberts requested a review from a team February 1, 2019 20:36

brandonroberts force-pushed the docs-examples-ivy branch from f37351a to d43b0b2 Compare February 1, 2019 20:38

brandonroberts requested a review from a team February 1, 2019 20:38

brandonroberts force-pushed the docs-examples-ivy branch from d43b0b2 to 4bdecd1 Compare February 4, 2019 13:15

brandonroberts force-pushed the docs-examples-ivy branch 2 times, most recently from 39936aa to 2d02433 Compare February 5, 2019 19:10

brandonroberts force-pushed the docs-examples-ivy branch 3 times, most recently from 0739323 to 0517871 Compare February 8, 2019 18:02

brandonroberts added the target: major This PR is targeted for the next major release label Feb 8, 2019

ci(docs-infra): test docs examples with Ivy

f514575

brandonroberts force-pushed the docs-examples-ivy branch from 0517871 to f514575 Compare February 8, 2019 18:27

kara approved these changes Feb 8, 2019

View reviewed changes

IgorMinar approved these changes Feb 9, 2019

View reviewed changes

IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 9, 2019

mhevery closed this in 99e3a04 Feb 11, 2019

gkalpak reviewed Feb 12, 2019

View reviewed changes

gkalpak pushed a commit to gkalpak/angular that referenced this pull request Feb 13, 2019

ci(docs-infra): test docs examples with Ivy (angular#28463)

d2deab3

PR Close angular#28463

This was referenced Feb 13, 2019

docs-infra: backporting #28592, #28463 and #28650 #28713

Closed

docs-infra: backporting #28592, #28463, #28650, #28688, #28663 #28714

Merged

gkalpak pushed a commit to gkalpak/angular that referenced this pull request Feb 14, 2019

ci(docs-infra): test docs examples with Ivy (angular#28463)

026bb9b

PR Close angular#28463

kara added the comp: ivy label Feb 25, 2019

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019

Conversation

brandonroberts commented Jan 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Uh oh!

mary-poppins commented Jan 31, 2019

Uh oh!

mary-poppins commented Jan 31, 2019

Uh oh!

mary-poppins commented Feb 1, 2019

Uh oh!

brandonroberts commented Feb 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mary-poppins commented Feb 1, 2019

Uh oh!

mary-poppins commented Feb 1, 2019

Uh oh!

mary-poppins commented Feb 4, 2019

Uh oh!

mary-poppins commented Feb 4, 2019

Uh oh!

mary-poppins commented Feb 4, 2019

Uh oh!

mary-poppins commented Feb 4, 2019

Uh oh!

brandonroberts commented Feb 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocombe commented Feb 5, 2019

Uh oh!

mary-poppins commented Feb 5, 2019

Uh oh!

mary-poppins commented Feb 8, 2019

Uh oh!

mary-poppins commented Feb 8, 2019

Uh oh!

mary-poppins commented Feb 8, 2019

Uh oh!

mary-poppins commented Feb 8, 2019

Uh oh!

kara left a comment

Choose a reason for hiding this comment

Uh oh!

IgorMinar left a comment

Choose a reason for hiding this comment

Uh oh!

brandonroberts commented Feb 11, 2019

Uh oh!

gkalpak Feb 12, 2019

Choose a reason for hiding this comment

Uh oh!

gkalpak Feb 12, 2019

Choose a reason for hiding this comment

Uh oh!

gkalpak Feb 12, 2019

Choose a reason for hiding this comment

Uh oh!

angular-automatic-lock-bot Bot commented Sep 14, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

brandonroberts commented Jan 31, 2019 •

edited

Loading

brandonroberts commented Feb 1, 2019 •

edited

Loading

brandonroberts commented Feb 4, 2019 •

edited

Loading