Skip to content

[7.2.x] ivy+docs-infra: compile angular.io with Ivy - #28421

Closed
gkalpak wants to merge 8 commits into
angular:7.2.xfrom
gkalpak:7.2.x-ci-aio-compile-with-ivy
Closed

[7.2.x] ivy+docs-infra: compile angular.io with Ivy#28421
gkalpak wants to merge 8 commits into
angular:7.2.xfrom
gkalpak:7.2.x-ci-aio-compile-with-ivy

Conversation

@gkalpak

@gkalpak gkalpak commented Jan 29, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Backports most commits from #26947 to 7.2.x.

Most ivy-related changes are merged into master only, so building aio with ivy does not work on 7.2.x, but as many of the changes as possible have been backported in order to avoid unnecessary deviation of the master branch and reduce the likelihood of merge conflicts for future backports to 7.2.x.

@gkalpak
gkalpak requested review from a team January 29, 2019 12:00
@gkalpak gkalpak added action: review The PR is still awaiting reviews from at least one requested reviewer comp: docs-infra labels Jan 29, 2019
@ngbot ngbot Bot added this to the needsTriage milestone Jan 29, 2019
@gkalpak

gkalpak commented Jan 29, 2019

Copy link
Copy Markdown
Member Author

merge-assistance: The test_ivy_aot failure is "inherited" from upstream.

petebacondarwin
petebacondarwin reviewed Jan 29, 2019
View reviewed changes

@petebacondarwin petebacondarwin left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message in

refactor(docs-infra): get rid of on component input

is no longer accurate.

Ivy does allow this, but we are choosing to refactor it for other reasons.

@petebacondarwin

petebacondarwin commented Jan 29, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

I'm not convinced that

ci(docs-infra): compile with Ivy

should be backported, since we should not be trying to compile with ivy in 7.2.x, right?

Oh and then I saw:

fixup! ci(docs-infra): compile with Ivy

where you comment it out :-)

petebacondarwin
petebacondarwin suggested changes Jan 29, 2019
View reviewed changes

@petebacondarwin petebacondarwin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one change to the commit message - otherwise LGTM

@gkalpak
gkalpak force-pushed the 7.2.x-ci-aio-compile-with-ivy branch from 0046d95 to 84512a9 Compare January 29, 2019 14:14
@gkalpak

gkalpak commented Jan 29, 2019

Copy link
Copy Markdown
Member Author

Updated the commit message.

@matsko matsko added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 4, 2019
matsko pushed a commit that referenced this pull request Feb 4, 2019
@gkalpak @matsko
refactor(core): remove duplicate check in defaultStyleSanitizer (#2…
a9a095d 
…8421)

PR Close #28421
matsko pushed a commit that referenced this pull request Feb 4, 2019
@gkalpak @matsko
fix(ivy): add missing private render3 exports (#28421)
114519a 
PR Close #28421
matsko pushed a commit that referenced this pull request Feb 4, 2019
@gkalpak @matsko
refactor(docs-infra): get rid of on component input (#28421)
e6325eb 
PR Close #28421
matsko pushed a commit that referenced this pull request Feb 4, 2019
@gkalpak @matsko
build(docs-infra): upgrade @angular/cli to 7.2.1 (#28421)
b71d198 
PR Close #28421
matsko pushed a commit that referenced this pull request Feb 4, 2019
@gkalpak @matsko
ci(docs-infra): compile with Ivy (#28421)
60c5ebd 
Jira: FW-552

PR Close #28421
matsko pushed a commit that referenced this pull request Feb 4, 2019
@gkalpak @matsko
refactor: correctly name cli-hello-world-ivy project to distinguish…
1da403d 
… from `cli-hello-world` in logs (#28421)

PR Close #28421
matsko pushed a commit that referenced this pull request Feb 4, 2019
@gkalpak @matsko
test: log cli version in cli-hello-world[-ivy] integration projects (…
c64e666 
…#28421)

This helps debug issues on CI.

PR Close #28421
@gkalpak

gkalpak commented Feb 4, 2019

Copy link
Copy Markdown
Member Author

Merged as a9a095d44 - c64e66675.

@gkalpak gkalpak closed this Feb 4, 2019
@gkalpak
gkalpak deleted the 7.2.x-ci-aio-compile-with-ivy branch February 4, 2019 17:10
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 14, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@petebacondarwin petebacondarwin petebacondarwin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

4 participants

@gkalpak @petebacondarwin @matsko @googlebot