feat(docs-infra): white background and corresponding figure updates by sjtrimble · Pull Request #28396 · angular/angular

sjtrimble · 2019-01-28T00:08:32Z

Update layout background to white for improved legibility
Update figure styles to be more visually appealing and easily identifiable in new white background (similar to Google Material Design documentation site examples)

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Issue Number: #23983

What is the new behavior?

White background on general layout where reading text can be found
Figures now have a gray lightbox to be more easily identifiable and its images sit within a card to match the Material Design guidelines / styles

Does this PR introduce a breaking change?

Yes
No

Other information

sjtrimble · 2019-01-28T00:10:39Z

Updated figures style for reference:

Format requires:
<figure class="lightbox">...
<div class="card">...
<img>...

FYI @jenniferfell

mary-poppins · 2019-01-28T00:13:58Z

You can preview b888309 at https://pr28396-b888309.ngbuilds.io/.

mary-poppins · 2019-01-28T00:18:37Z

You can preview 024cb08 at https://pr28396-024cb08.ngbuilds.io/.

mary-poppins · 2019-01-28T00:18:45Z

You can preview 6cc8a85 at https://pr28396-6cc8a85.ngbuilds.io/.

IgorMinar · 2019-01-28T04:15:18Z

If I run accessibility test against the homepage preview of this pr at web.dev I still get the following warning:

IgorMinar · 2019-01-28T04:16:22Z

Can you please take a look and test the preview urls on web.dev? Thanks!

sjtrimble · 2019-01-30T00:34:24Z

Yes I'll take a look. I'm not sure why it's saying that because a lot of the colors meet WCAG AAA requirements.

mary-poppins · 2019-01-30T19:59:19Z

You can preview a2a866c at https://pr28396-a2a866c.ngbuilds.io/.

mary-poppins · 2019-01-30T20:04:55Z

You can preview faa0f3d at https://pr28396-faa0f3d.ngbuilds.io/.

sjtrimble · 2019-01-30T20:06:08Z

I ran a check on several of the elements - see the color contrast scores. I did update the footer to meet WCAG AA requirements.

mary-poppins · 2019-01-30T20:11:50Z

You can preview c072a15 at https://pr28396-c072a15.ngbuilds.io/.

mary-poppins · 2019-01-30T20:26:15Z

You can preview fe5094c at https://pr28396-fe5094c.ngbuilds.io/.

petebacondarwin · 2019-02-11T15:14:37Z

Accessibility report looks pretty good now: https://lighthouse-dot-webdotdevsite.appspot.com/lh/html?url=https://pr28396-fe5094c.ngbuilds.io/

petebacondarwin · 2019-02-11T15:15:31Z

@sjtrimble I think you will need to rebase to fix the CI build failure.

mary-poppins · 2019-02-11T20:02:58Z

You can preview 7a34c7b at https://pr28396-7a34c7b.ngbuilds.io/.

sjtrimble · 2019-02-11T20:03:03Z

@petebacondarwin I just rebased and pushed, hopefully that fixes the build failure. I will work on the other accessibility items separately and work through replacing the figures with the new layout throughout the site.

petebacondarwin · 2019-02-13T12:15:02Z

re-ran jobs a few times but this seems to fail consistently

sjtrimble · 2019-04-16T21:01:53Z

@petebacondarwin This never got merged, right? What do we need to do to move it forward (besides rebasing)?

petebacondarwin · 2019-04-17T06:25:01Z

Can you ensure that the e2e tests pass please.

mary-poppins · 2019-05-31T21:13:50Z

You can preview 621cdea at https://pr28396-621cdea.ngbuilds.io/.

mary-poppins · 2019-06-05T18:58:40Z

You can preview af60549 at https://pr28396-af60549.ngbuilds.io/.

sjtrimble · 2019-06-06T19:01:38Z

@petebacondarwin Ready for you to review/approve, tests are now passing

…28396) PR Close #28396

angular-automatic-lock-bot · 2019-09-15T04:22:27Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

sjtrimble added the comp: docs-infra label Jan 28, 2019

sjtrimble requested review from a team, brandonroberts and gkalpak January 28, 2019 00:08

googlebot added the cla: yes label Jan 28, 2019

ngbot Bot added this to the needsTriage milestone Jan 28, 2019

sjtrimble force-pushed the bgcolor-cards-figures branch 2 times, most recently from 024cb08 to 6cc8a85 Compare January 28, 2019 00:14

sjtrimble force-pushed the bgcolor-cards-figures branch from 6cc8a85 to a2a866c Compare January 30, 2019 19:54

sjtrimble force-pushed the bgcolor-cards-figures branch from a2a866c to faa0f3d Compare January 30, 2019 19:59

sjtrimble force-pushed the bgcolor-cards-figures branch from faa0f3d to c072a15 Compare January 30, 2019 20:06

sjtrimble force-pushed the bgcolor-cards-figures branch from c072a15 to fe5094c Compare January 30, 2019 20:21

petebacondarwin approved these changes Feb 11, 2019

View reviewed changes

sjtrimble force-pushed the bgcolor-cards-figures branch from fe5094c to 7a34c7b Compare February 11, 2019 19:58

sjtrimble force-pushed the bgcolor-cards-figures branch from 7a34c7b to 621cdea Compare May 31, 2019 21:04

feat(docs-infra): white background and corresponding figure updates

af60549

sjtrimble force-pushed the bgcolor-cards-figures branch from 621cdea to af60549 Compare June 5, 2019 18:50

brandonroberts added effort3: weeks target: patch This PR is targeted for the next patch release risk: medium refactoring Issue that involves refactoring or code-cleanup labels Jun 5, 2019

ngbot Bot modified the milestones: needsTriage, Backlog Jun 5, 2019

petebacondarwin approved these changes Jun 6, 2019

View reviewed changes

petebacondarwin removed request for brandonroberts and gkalpak June 6, 2019 19:12

petebacondarwin added the action: merge The PR is ready for merge by the caretaker label Jun 6, 2019

mhevery pushed a commit that referenced this pull request Jun 6, 2019

feat(docs-infra): white background and corresponding figure updates (#…

be82270

…28396) PR Close #28396

mhevery closed this in 383ab85 Jun 6, 2019

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019

Conversation

sjtrimble commented Jan 28, 2019

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Uh oh!

sjtrimble commented Jan 28, 2019

Uh oh!

mary-poppins commented Jan 28, 2019

Uh oh!

mary-poppins commented Jan 28, 2019

Uh oh!

mary-poppins commented Jan 28, 2019

Uh oh!

IgorMinar commented Jan 28, 2019

Uh oh!

IgorMinar commented Jan 28, 2019

Uh oh!

sjtrimble commented Jan 30, 2019

Uh oh!

mary-poppins commented Jan 30, 2019

Uh oh!

mary-poppins commented Jan 30, 2019

Uh oh!

sjtrimble commented Jan 30, 2019

Uh oh!

mary-poppins commented Jan 30, 2019

Uh oh!

mary-poppins commented Jan 30, 2019

Uh oh!

petebacondarwin commented Feb 11, 2019

Uh oh!

petebacondarwin commented Feb 11, 2019

Uh oh!

mary-poppins commented Feb 11, 2019

Uh oh!

sjtrimble commented Feb 11, 2019

Uh oh!

petebacondarwin commented Feb 13, 2019

Uh oh!

sjtrimble commented Apr 16, 2019

Uh oh!

petebacondarwin commented Apr 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mary-poppins commented May 31, 2019

Uh oh!

mary-poppins commented Jun 5, 2019

Uh oh!

sjtrimble commented Jun 6, 2019

Uh oh!

angular-automatic-lock-bot Bot commented Sep 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

petebacondarwin commented Apr 17, 2019 •

edited

Loading