Repository navigation
feat(compiler): content projection during compile - #2839
Merged
Merged
Conversation
tbosch
force-pushed
the
render-project
branch
6 times, most recently
from
July 13, 2015 17:20
48fe268 to
fac8545
Compare
tbosch
changed the title
tbosch
added
action: review
Contributor
Author
There was a problem hiding this comment.
Add 'root' not implicitly but explictly to the left hand side
tbosch
force-pushed
the
render-project
branch
2 times, most recently
from
July 14, 2015 00:33
a0c8ace to
3d16356
Compare
Contributor
Author
There was a problem hiding this comment.
modify hostProtoView
Contributor
Author
There was a problem hiding this comment.
modify the DOM of ...
Contributor
Author
There was a problem hiding this comment.
name 'nested' is wrong here, as the host is included as well.
Contributor
Author
|
Reviewed in person with @vsavkin |
tbosch
added
pr_state: LGTM
action: cleanup
This was referenced Jul 14, 2015
Closed
tbosch
force-pushed
the
render-project
branch
7 times, most recently
from
July 16, 2015 02:50
08fcad4 to
f7e58b7
Compare
…ation. Closes angular#2529 BREAKING CHANGES: - shadow dom emulation no longer supports the `<content>` tag. Use the new `<ng-content>` instead (works with all shadow dom strategies). - removed `DomRenderer.setViewRootNodes` and `AppViewManager.getComponentView` -> use `DomRenderer.getNativeElementSync(elementRef)` and change shadow dom directly - the `Renderer` interface has changed: * `createView` now also has to support sub views * the notion of a container has been removed. Instead, the renderer has to implement methods to attach views next to elements or other views. * a RenderView now contains multiple RenderFragments. Fragments are used to move DOM nodes around. Internal changes / design changes: - Introduce notion of view fragments on render side - DomProtoViews and DomViews on render side are merged, AppProtoViews are not merged, AppViews are partially merged (they share arrays with the other merged AppViews but we keep individual AppView instances for now). - DomProtoViews always have a `<template>` element as root * needed for storing subviews * we have less chunks of DOM to clone now - remove fake ElementBinder / Bound element for root text bindings and model them explicitly. This removes a lot of special cases we had! - AppView shares data with nested component views - some methods in AppViewManager (create, hydrate, dehydrate) are iterative now * now possible as we have all child AppViews / ElementRefs already in an array!
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2529
BREAKING CHANGES:
supports the
<content>tag. Use the new<ng-content>instead(works with all shadow dom strategies).
DomRenderer.setViewRootNodesandAppViewManager.getComponentView-> use
DomRenderer.getNativeElementSync(elementRef)and change shadow dom directlyRendererinterface has changed:createViewnow also has to support sub viewsto implement methods to attach views next to elements or other views.
are used to move DOM nodes around.
Internal changes:
<template>element as rootand model them explicitly. This removes a lot of special cases we had!