Repository navigation
Conversation
| const children = route.get('children'); | ||
| if (Array.isArray(children)) { | ||
| recursivelyScanRoutes(routes); | ||
| recursivelyScanRoutes(children); |
petebacondarwin
approved these changes
Jan 25, 2019
| expect(routes[0].referencedModule.filePath.endsWith('/lazy.ts')).toBe(true); | ||
| }); | ||
|
|
||
| it('should detect no lazy routes for simple children routes', () => { |
Contributor
There was a problem hiding this comment.
I assume that this got stuck in an infinite recursion previously?
petebacondarwin
added
action: review
alxhub
approved these changes
Jan 25, 2019
gkalpak
suggested changes
Jan 28, 2019
| imports: [ | ||
| RouterModule.forRoot([ | ||
| {path: '', children: [ | ||
| {path: 'foo', component: FooCmp} |
Member
There was a problem hiding this comment.
The test is enough to show that we are not stuck in infinite recursion, but having some actual lazy-loaded children to show that they are correctly picked up, would be a good idea imo 😉
Member
Author
There was a problem hiding this comment.
You mean like:
RouterModule.forRoot([
{path: '', children: [
{path: 'foo', component: FooCmp},
{path: 'lazy', loadChildren: './lazy#LazyModule'}
]},
]),
?
gkalpak
approved these changes
Jan 28, 2019
gkalpak
added
action: merge
Member
|
merge-assistance: Needs g3sync. |
Contributor
|
Error running presubmit. Need to debug. |
Contributor
vetom
pushed a commit
to vetom/angular
that referenced
this pull request
Jan 31, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Now that PR #27697 landed for lazy route analysis in ngtsc, a simple route config with:
results in a
ERROR in Maximum call stack size exceededwhen runningngtsc.What is the new behavior?
This PR fixes the infinite recursion introduced and adds a simple test that demonstrates it
(without the fix, the test itself triggers an infinite loop).
Does this PR introduce a breaking change?