Skip to content

build: switch to typescript's es2015 typings#28134

Closed
alexeagle wants to merge 1 commit into
angular:masterfrom
alexeagle:lib_es2015
Closed

build: switch to typescript's es2015 typings#28134
alexeagle wants to merge 1 commit into
angular:masterfrom
alexeagle:lib_es2015

Conversation

@alexeagle

@alexeagle alexeagle commented Jan 14, 2019

Copy link
Copy Markdown
Contributor

Note that this allows Angular to depend on the entirety of the ES2015 API, not just our restricted subset.
This change is needed because our copy of the subset was out-of-date, and prevents us using ES2015 target in dev mode.

@alexeagle alexeagle requested a review from IgorMinar as a code owner January 14, 2019 18:12
@mary-poppins

mary-poppins commented Jan 14, 2019

Copy link
Copy Markdown

You can preview c9ea010 at https://pr28134-c9ea010.ngbuilds.io/.

@alexeagle alexeagle added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jan 14, 2019
@mary-poppins

mary-poppins commented Jan 14, 2019

Copy link
Copy Markdown

You can preview 8a77e5d at https://pr28134-8a77e5d.ngbuilds.io/.

@alexeagle
build: switch to typescript's es2015 typings
fbc3e38 
Note that this allows Angular to depend on the entirety of the ES2015 API, not just our restricted subset.
This change is needed because our copy of the subset was out-of-date, and prevents us using ES2015 target in dev mode.

This is a subset of angular#27738
@mary-poppins

mary-poppins commented Jan 14, 2019

Copy link
Copy Markdown

You can preview fbc3e38 at https://pr28134-fbc3e38.ngbuilds.io/.

@alexeagle

alexeagle commented Jan 14, 2019

Copy link
Copy Markdown
Contributor Author

CARETAKER: http://cl/229233121 has a change to third_party/javascript/angular2/BUILD which is required to g3sync this PR

IgorMinar
IgorMinar approved these changes Jan 15, 2019
View reviewed changes

@IgorMinar IgorMinar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 15, 2019
@AndrewKushnir AndrewKushnir added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jan 15, 2019
@AndrewKushnir

AndrewKushnir commented Jan 15, 2019

Copy link
Copy Markdown
Contributor

The changes produced some issues in g3 (caught by trying to land g3-only changes first), so I mark this PR with "cleanup" label.

@jasonaden jasonaden added the area: build & ci Related the build and CI infrastructure of the project label Jan 24, 2019
@ngbot ngbot Bot added this to the needsTriage milestone Jan 24, 2019
@alexeagle alexeagle added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 5, 2019
@matsko matsko closed this in dde7e2f Feb 5, 2019
matsko pushed a commit that referenced this pull request Feb 5, 2019
@alexeagle @matsko
build: switch to typescript's es2015 typings (#28134)
a6fd118 
Note that this allows Angular to depend on the entirety of the ES2015 API, not just our restricted subset.
This change is needed because our copy of the subset was out-of-date, and prevents us using ES2015 target in dev mode.

This is a subset of #27738

PR Close #28134
matsko added a commit to matsko/angular that referenced this pull request Feb 5, 2019
@matsko
Revert "build: switch to typescript's es2015 typings (angular#28134)"
917f62f 
This reverts commit dde7e2f.
matsko added a commit that referenced this pull request Feb 5, 2019
@matsko
revert: build: switch to typescript's es2015 typings (#28134)
fe4d811 
This reverts commit dde7e2f.
matsko added a commit that referenced this pull request Feb 5, 2019
@matsko
revert: build: switch to typescript's es2015 typings (#28134)
483e8d2 
This reverts commit a6fd118.
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 14, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@IgorMinar IgorMinar IgorMinar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

6 participants

@alexeagle @mary-poppins @AndrewKushnir @IgorMinar @jasonaden @googlebot