Skip to content

refactor(ivy): refactor more files in DI to prepare it for hazel packages#28098

Closed
mhevery wants to merge 2 commits into
angular:masterfrom
mhevery:refactor_di_for_separate_bazel_packages
Closed

refactor(ivy): refactor more files in DI to prepare it for hazel packages#28098
mhevery wants to merge 2 commits into
angular:masterfrom
mhevery:refactor_di_for_separate_bazel_packages

Conversation

@mhevery

@mhevery mhevery commented Jan 12, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@mhevery mhevery requested review from a team January 12, 2019 06:03
@mary-poppins

Copy link
Copy Markdown

You can preview 6a83f51 at https://pr28098-6a83f51.ngbuilds.io/.

@mhevery mhevery force-pushed the refactor_di_for_separate_bazel_packages branch from 6a83f51 to d15ddf1 Compare January 12, 2019 06:07
@mary-poppins

Copy link
Copy Markdown

You can preview d15ddf1 at https://pr28098-d15ddf1.ngbuilds.io/.

@IgorMinar

Copy link
Copy Markdown
Contributor

Ci is not happy though. Please fix.

@mhevery mhevery force-pushed the refactor_di_for_separate_bazel_packages branch from d15ddf1 to b85876d Compare January 12, 2019 07:59
@mary-poppins

Copy link
Copy Markdown

You can preview b85876d at https://pr28098-b85876d.ngbuilds.io/.

@mary-poppins

Copy link
Copy Markdown

You can preview bb0665f at https://pr28098-bb0665f.ngbuilds.io/.

@mhevery mhevery force-pushed the refactor_di_for_separate_bazel_packages branch from bb0665f to df3926f Compare January 12, 2019 08:35
@mhevery mhevery added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Jan 12, 2019
@mary-poppins

Copy link
Copy Markdown

You can preview df3926f at https://pr28098-df3926f.ngbuilds.io/.

@mhevery mhevery force-pushed the refactor_di_for_separate_bazel_packages branch from df3926f to 7c890e8 Compare January 12, 2019 09:04
@mhevery mhevery requested a review from a team January 12, 2019 09:04
@mhevery mhevery force-pushed the refactor_di_for_separate_bazel_packages branch 2 times, most recently from 26260ad to 26bea32 Compare January 12, 2019 20:19
@mhevery mhevery requested review from a team January 12, 2019 20:19
@mary-poppins

Copy link
Copy Markdown

You can preview 26bea32 at https://pr28098-26bea32.ngbuilds.io/.

@mhevery mhevery force-pushed the refactor_di_for_separate_bazel_packages branch from 26bea32 to b10b506 Compare January 12, 2019 20:28
@mary-poppins

Copy link
Copy Markdown

You can preview b10b506 at https://pr28098-b10b506.ngbuilds.io/.

@mhevery

mhevery commented Jan 12, 2019

Copy link
Copy Markdown
Contributor Author

@AndrewKushnir

Copy link
Copy Markdown
Contributor

Presubmit #2

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants