Skip to content

docs: remove deprecated fromPromise from RxJS guide - #28015

Closed
gkalpak wants to merge 1 commit into
angular:masterfrom
gkalpak:docs-rxjs
Closed

gkalpak wants to merge 1 commit into
angular:masterfrom
gkalpak:docs-rxjs

Conversation

@gkalpak

@gkalpak gkalpak commented Jan 9, 2019

Copy link
Copy Markdown
Member

Follow-up to #27443.

@gkalpak
gkalpak requested a review from a team January 9, 2019 14:44
@gkalpak gkalpak added comp: docs action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jan 9, 2019
@ngbot ngbot Bot added this to the needsTriage milestone Jan 9, 2019
@mary-poppins

Copy link
Copy Markdown

You can preview bcc176f at https://pr28015-bcc176f.ngbuilds.io/.

@gkalpak

gkalpak commented Jan 9, 2019

Copy link
Copy Markdown
Member Author

Also created #28017 to track not having tests for the RxJS guide examples.

@benlesh benlesh added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 9, 2019
AndrewKushnir pushed a commit that referenced this pull request Jan 9, 2019
@gkalpak
gkalpak deleted the docs-rxjs branch January 10, 2019 10:57
AndrewKushnir pushed a commit that referenced this pull request Jan 16, 2019
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants