Skip to content

docs: document why not using compare-url orb - #28010

Closed
gkalpak wants to merge 1 commit into
angular:masterfrom
gkalpak:docs-why-not-compare-url-orb
Closed

docs: document why not using compare-url orb#28010
gkalpak wants to merge 1 commit into
angular:masterfrom
gkalpak:docs-why-not-compare-url-orb

Conversation

@gkalpak

@gkalpak gkalpak commented Jan 9, 2019

Copy link
Copy Markdown
Member

Discussed in #27775 (comment).

@gkalpak
gkalpak requested a review from a team January 9, 2019 12:43
@gkalpak gkalpak added comp: docs area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jan 9, 2019
@ngbot ngbot Bot modified the milestone: needsTriage Jan 9, 2019
@gkalpak gkalpak mentioned this pull request Jan 9, 2019
Closed
IgorMinar
IgorMinar approved these changes Jan 10, 2019
View reviewed changes

@IgorMinar IgorMinar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 10, 2019
AndrewKushnir pushed a commit that referenced this pull request Jan 10, 2019
@gkalpak @AndrewKushnir
docs: document why not using compare-url orb (#28010)
acb69e8 
Discussed in
#27775 (comment).

PR Close #28010
@gkalpak
gkalpak deleted the docs-why-not-compare-url-orb branch January 10, 2019 19:47
AndrewKushnir pushed a commit that referenced this pull request Jan 16, 2019
@gkalpak @AndrewKushnir
docs: document why not using compare-url orb (#28010)
2e0c58e 
Discussed in
#27775 (comment).

PR Close #28010
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 14, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@IgorMinar IgorMinar IgorMinar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

3 participants

@gkalpak @IgorMinar @googlebot