Skip to content

ci: fix public api rule in codeowners - #27999

Closed
IgorMinar wants to merge 1 commit into
angular:masterfrom
IgorMinar:ci/codeowners-fix-public-api-rule
Closed

IgorMinar wants to merge 1 commit into
angular:masterfrom
IgorMinar:ci/codeowners-fix-public-api-rule

Conversation

@IgorMinar

@IgorMinar IgorMinar commented Jan 8, 2019 •

Copy link
Copy Markdown
Contributor

@alxhub spotted that the public api rule in codeowners is being overridden by the Build & CI Owners rule.

swapping the two sections fixes the problem.

@alxhub spotted that the public api rule in codeowners is being overriden by the Build & CI Owners rule.

swapping the two sections fixes the problem.
@IgorMinar
IgorMinar requested a review from alxhub January 8, 2019 23:34
@IgorMinar IgorMinar added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project labels Jan 8, 2019
@ngbot ngbot Bot added this to the needsTriage milestone Jan 8, 2019
kara pushed a commit that referenced this pull request Jan 8, 2019
@alxhub spotted that the public api rule in codeowners is being overriden by the Build & CI Owners rule.

swapping the two sections fixes the problem.

PR Close #27999
@kara kara closed this in 3fba6ef Jan 8, 2019
AndrewKushnir pushed a commit that referenced this pull request Jan 16, 2019
@alxhub spotted that the public api rule in codeowners is being overriden by the Build & CI Owners rule.

swapping the two sections fixes the problem.

PR Close #27999
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants