Skip to content

test(ivy): re-enable passing animation tests - #27997

Closed
kara wants to merge 1 commit into
angular:masterfrom
kara:passing
Closed

test(ivy): re-enable passing animation tests#27997
kara wants to merge 1 commit into
angular:masterfrom
kara:passing

Conversation

@kara

@kara kara commented Jan 8, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@kara kara added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release comp: ivy labels Jan 8, 2019
@kara
kara requested a review from a team January 8, 2019 20:43
@ngbot ngbot Bot added this to the needsTriage milestone Jan 8, 2019
@mary-poppins

mary-poppins commented Jan 8, 2019

Copy link
Copy Markdown

You can preview dbbe57a at https://pr27997-dbbe57a.ngbuilds.io/.

@mary-poppins

mary-poppins commented Jan 8, 2019

Copy link
Copy Markdown

You can preview a8eb051 at https://pr27997-a8eb051.ngbuilds.io/.

@mary-poppins

mary-poppins commented Jan 8, 2019

Copy link
Copy Markdown

You can preview ddb1325 at https://pr27997-ddb1325.ngbuilds.io/.

@mhevery mhevery added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 8, 2019
@ngbot

ngbot Bot commented Jan 8, 2019

Copy link
Copy Markdown

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: legacy-unit-tests-saucelabs" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@kara kara closed this in 1a7f92c Jan 8, 2019
kara added a commit that referenced this pull request Jan 8, 2019
@kara
test(ivy): re-enable passing animation tests (#27997)
097af5a 
PR Close #27997
@kara kara added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Jan 9, 2019
kara added a commit that referenced this pull request Jan 9, 2019
@kara
Revert "test(ivy): re-enable passing animation tests (#27997)"
5a7dd73 
This reverts commit 097af5a.
It was accidentally merged on both master and patch branches when
it should have only been merged on master.
AndrewKushnir pushed a commit that referenced this pull request Jan 16, 2019
@kara @AndrewKushnir
test(ivy): re-enable passing animation tests (#27997)
aee5cbd 
PR Close #27997
AndrewKushnir pushed a commit that referenced this pull request Jan 16, 2019
@kara @AndrewKushnir
Revert "test(ivy): re-enable passing animation tests (#27997)"
37a6d2d 
This reverts commit 097af5a.
It was accidentally merged on both master and patch branches when
it should have only been merged on master.
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 14, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@mhevery mhevery mhevery approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

4 participants

@kara @mary-poppins @mhevery @googlebot