Repository navigation
Conversation
kara
added
action: review
IgorMinar
approved these changes
Jan 8, 2019
IgorMinar
left a comment
IgorMinar
left a comment
Contributor
There was a problem hiding this comment.
can you swap "bug fixes" and "features" sections please? for major/minor release people usually care more (expect) feature list rather than bugfix list.
also the forms PRs we merged should have been categorized as features and not as fixes. no? consider manually fixing the entries in the changelog.
otherwise lgtm
IgorMinar
added
action: cleanup
kara
removed
the
action: cleanup
Contributor
Author
|
@IgorMinar Okay, switched the sections, moved the forms commit to features, and added a brief note that |
kara
added
action: merge
kara
added a commit
that referenced
this pull request
Jan 8, 2019
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 16, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes up CHANGELOG