Repository navigation
Conversation
…s-only-changes I’ve observed that Brandon reviews many docs-only PRs and then we still need me or Jeniffer to approve them. In most cases, Brandon is perfectly qualified to approve these, so I’m proposing that Brandon is added to the framework-global-approvers-for-docs-only-changes group.
IgorMinar
force-pushed
the
ci/add-brandon-to-docs-approvers
branch
from
January 6, 2019 07:50
f5b408b to
f074f59
Compare
IgorMinar
added
target: patch
Contributor
|
@IgorMinar I'm ok with this and I'm willing to be more careful about keeping the scope to only docs. I think this is a good change and I'll still reach out to the appropriate person if it needs further review. |
brandonroberts
approved these changes
Jan 7, 2019
Contributor
Author
|
@brandonroberts thanks |
kara
pushed a commit
that referenced
this pull request
Jan 7, 2019
…s-only-changes (#27949) I’ve observed that Brandon reviews many docs-only PRs and then we still need me or Jeniffer to approve them. In most cases, Brandon is perfectly qualified to approve these, so I’m proposing that Brandon is added to the framework-global-approvers-for-docs-only-changes group. PR Close #27949
Contributor
Author
|
fyi: I've just added @brandonroberts to the github team, so this change is not in effect. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 16, 2019
…s-only-changes (#27949) I’ve observed that Brandon reviews many docs-only PRs and then we still need me or Jeniffer to approve them. In most cases, Brandon is perfectly qualified to approve these, so I’m proposing that Brandon is added to the framework-global-approvers-for-docs-only-changes group. PR Close #27949
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’ve observed that Brandon reviews many docs-only PRs and then we still need me or Jeniffer to approve them. In most cases, Brandon is perfectly qualified to approve these, so I’m proposing that Brandon is added to the framework-global-approvers-for-docs-only-changes group.
@brandonroberts are you ok with this? this change will make you more "dangerous" because will mean that you will need to be much more careful when approving PRs because you could accidentally approve changes that impact also code and not only docs. If you are willing to be more careful, we trust you to not approve code changes for areas outside of your other areas of code ownership (currently only stuff owned by @angular/fw-docs-intro).
Please note that this change is for documentation purposes only, once this PR is approved and merged the actual change needs to be made in the github team settings by an admin