Repository navigation
fix(bazel): protractor utils cannot start server on windows - #27915
Closed
devversion wants to merge 1 commit into
Closed
devversion wants to merge 1 commit into
devversion wants to merge 1 commit into
Conversation
devversion
commented
Jan 3, 2019
devversion
commented
Member
- Currently the protractor utils assume that the specified Bazel server runfile can be resolved by just using the real file system. This is not the case on Windows because the runfiles are not symlinked into the working directory and need to be resolved through the runfile manifest.
devversion
added
action: review
devversion
added
the
hotlist: components team
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
devversion
force-pushed
the
fix/bazel-protractor-utils-windows-server
branch
from
January 3, 2019 20:14
0dc1788 to
c627eea
Compare
This comment has been minimized.
This comment has been minimized.
|
You can preview 8344b50 at https://pr27915-8344b50.ngbuilds.io/. |
Contributor
|
@devversion could you please rebase from the latest master? There was a problem with one test (causing |
gkalpak
reviewed
Jan 4, 2019
devversion
force-pushed
the
fix/bazel-protractor-utils-windows-server
branch
from
January 4, 2019 18:31
8344b50 to
9db97fb
Compare
Member
Author
|
@AndrewKushnir Rebased. Thanks for the heads up. |
|
You can preview 9db97fb at https://pr27915-9db97fb.ngbuilds.io/. |
* Currently the protractor utils assume that the specified Bazel server runfile can be resolved by just using the real file system. This is not the case on Windows because the runfiles are not symlinked into the working directory and need to be resolved through the runfile manifest.
devversion
force-pushed
the
fix/bazel-protractor-utils-windows-server
branch
from
January 7, 2019 11:28
9db97fb to
cb7eb6a
Compare
|
You can preview cb7eb6a at https://pr27915-cb7eb6a.ngbuilds.io/. |
alexeagle
approved these changes
Jan 7, 2019
alexeagle
added
action: merge
Contributor
|
caretaker: pullapprove not marking this green, though it has required reviews |
alexeagle
removed
the
merge: caretaker note
kara
pushed a commit
that referenced
this pull request
Jan 7, 2019
* Currently the protractor utils assume that the specified Bazel server runfile can be resolved by just using the real file system. This is not the case on Windows because the runfiles are not symlinked into the working directory and need to be resolved through the runfile manifest. PR Close #27915
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 16, 2019
* Currently the protractor utils assume that the specified Bazel server runfile can be resolved by just using the real file system. This is not the case on Windows because the runfiles are not symlinked into the working directory and need to be resolved through the runfile manifest. PR Close #27915
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.