Repository navigation
fix(ivy): identify all ESM5 decorated classes - #27848
Closed
petebacondarwin wants to merge 1 commit into
Closed
petebacondarwin wants to merge 1 commit into
petebacondarwin wants to merge 1 commit into
Conversation
|
You can preview 1598e41 at https://pr27848-1598e41.ngbuilds.io/. |
petebacondarwin
force-pushed
the
ngcc-find-esm5-decorated-classes
branch
from
December 27, 2018 22:08
1598e41 to
e87a297
Compare
|
You can preview e87a297 at https://pr27848-e87a297.ngbuilds.io/. |
petebacondarwin
force-pushed
the
ngcc-find-esm5-decorated-classes
branch
from
December 28, 2018 08:29
e87a297 to
da9bacf
Compare
|
You can preview da9bacf at https://pr27848-da9bacf.ngbuilds.io/. |
petebacondarwin
force-pushed
the
ngcc-find-esm5-decorated-classes
branch
from
December 29, 2018 14:37
da9bacf to
40f2886
Compare
|
You can preview 40f2886 at https://pr27848-40f2886.ngbuilds.io/. |
Contributor
alan-agius4
approved these changes
Jan 8, 2019
4 tasks done
alxhub
approved these changes
Jan 9, 2019
JoostK
reviewed
Jan 11, 2019
Member
There was a problem hiding this comment.
isAssignmentStatement has now gone unused it seems.
In ESM5 decorated classes can be indicated by calls to `__decorate()`. Previously the `ReflectionHost.findDecoratedClasses()` call would identify helper calls of the form: ``` SomeClass = tslib_1.__decorate(...); ``` But it was missing calls of the form: ``` SomeClass = SomeClass_1 = tslib_1.__decorate(...); ``` This form is common in `@NgModule()` decorations, where the class being decorated is referenced inside the decorator or another member. This commit now ensures that a chain of assignments, of any length, is now identified as a class decoration if it results in a call to `__decorate()`. Fixes angular#27841
petebacondarwin
force-pushed
the
ngcc-find-esm5-decorated-classes
branch
from
January 11, 2019 15:23
40f2886 to
d09190a
Compare
|
You can preview d09190a at https://pr27848-d09190a.ngbuilds.io/. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
Fixes #27841