Repository navigation
Fix ng_package tests not working on Windows - #27829
devversion wants to merge 5 commits into
Conversation
Currently when building a package on Windows, the typings re-export for secondary entry-points is not valid TypeScript. Similarly the metadata and the "package.json" files use non-posix paths and cause inconsistency within the NPM package. For example: _package.json_ ``` "esm5": "./esm5\\core.js", "esm2015": "./esm2015\\core.js", ``` _testing.d.t.s_ (of the `core` package) ``` export * from './testing\testing'; ```
* Enables the ng_package golden testing on the CI * Fixes the ng_package golden testing for Windows
devversion
added
action: review
This comment has been minimized.
This comment has been minimized.
|
@IgorMinar for your comment #27827 (review): there already were a few tests that should have detected these Windows issues if we would run with Buildkite. Since these tests didn't even run on CI, and also didn't work Windows, I've just fixed those for Windows and made sure that these can run on CircleCI now. Also added a few more requested test cases. |
|
You can preview 0427bb3 at https://pr27829-0427bb3.ngbuilds.io/. |
| deps = ["@ngdeps//diff"], | ||
| # We don't want to run the example_package golden test with Ivy yet. Currently the golden | ||
| # file is based on non-ivy output and therefore won't work for ngc and Ivy at the same time. | ||
| # TODO: We should be able to have another golden for ivy-aot as well. |
There was a problem hiding this comment.
Is there a Jira issue for that (to make sure we don't forget about it 😁)?
There was a problem hiding this comment.
I don't have access to Jira as Material doesn't use Jira. I have it on my personal list as a follow-up though.
There was a problem hiding this comment.
We currently have a separate ivy build, but I don't think that's the plan for releasing Ivy - I think we still want all the bits in a single package? so this todo might not make sense - we should assert on the content of the entire ivy-and-prior compat package.
There was a problem hiding this comment.
Not sure if my comment is a bit confusing, but I basically meant that we should somehow assert that in Ivy-mode the package output is also correct.
Since pre-ivy and ivy output different JS, we need two goldens. One for Ivy and one for pre-ivy.
| deps = ["@ngdeps//diff"], | ||
| # We don't want to run the example_package golden test with Ivy yet. Currently the golden | ||
| # file is based on non-ivy output and therefore won't work for ngc and Ivy at the same time. | ||
| # TODO: We should be able to have another golden for ivy-aot as well. |
There was a problem hiding this comment.
We currently have a separate ivy build, but I don't think that's the plan for releasing Ivy - I think we still want all the bits in a single package? so this todo might not make sense - we should assert on the content of the entire ivy-and-prior compat package.
alexeagle
added
action: merge
|
Caretaker: pullapprove not turning green, but it's approved by me |
alexeagle
removed
the
merge: caretaker note
* Enables the ng_package golden testing on the CI * Fixes the ng_package golden testing for Windows PR Close #27829
…27829) Currently when building a package on Windows, the typings re-export for secondary entry-points is not valid TypeScript. Similarly the metadata and the "package.json" files use non-posix paths and cause inconsistency within the NPM package. For example: _package.json_ ``` "esm5": "./esm5\\core.js", "esm2015": "./esm2015\\core.js", ``` _testing.d.t.s_ (of the `core` package) ``` export * from './testing\testing'; ``` PR Close #27829
* Enables the ng_package golden testing on the CI * Fixes the ng_package golden testing for Windows PR Close #27829
…27829) Currently when building a package on Windows, the typings re-export for secondary entry-points is not valid TypeScript. Similarly the metadata and the "package.json" files use non-posix paths and cause inconsistency within the NPM package. For example: _package.json_ ``` "esm5": "./esm5\\core.js", "esm2015": "./esm2015\\core.js", ``` _testing.d.t.s_ (of the `core` package) ``` export * from './testing\testing'; ``` PR Close #27829
* Enables the ng_package golden testing on the CI * Fixes the ng_package golden testing for Windows PR Close #27829
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
See individual commits for description of changes.