Skip to content

build: update to latest rules_typescript#27738

Closed
alexeagle wants to merge 2 commits into
angular:masterfrom
alexeagle:es2015
Closed

build: update to latest rules_typescript#27738
alexeagle wants to merge 2 commits into
angular:masterfrom
alexeagle:es2015

Conversation

@alexeagle

@alexeagle alexeagle commented Dec 18, 2018

Copy link
Copy Markdown
Contributor

This changes our devmode to es2015, so we now depend on the full es2015 typings.
Update a spot in the compiler which assumed es5 downleveling.

@alexeagle alexeagle requested a review from alxhub December 18, 2018 22:19
@mary-poppins

mary-poppins commented Dec 18, 2018

Copy link
Copy Markdown

You can preview d5b23eb at https://pr27738-d5b23eb.ngbuilds.io/.

@mary-poppins

mary-poppins commented Dec 18, 2018

Copy link
Copy Markdown

You can preview ae9e58f at https://pr27738-ae9e58f.ngbuilds.io/.

@mary-poppins

mary-poppins commented Dec 18, 2018

Copy link
Copy Markdown

You can preview 92d012b at https://pr27738-92d012b.ngbuilds.io/.

@mary-poppins

mary-poppins commented Dec 18, 2018

Copy link
Copy Markdown

You can preview fdacf0a at https://pr27738-fdacf0a.ngbuilds.io/.

alxhub
alxhub approved these changes Dec 18, 2018
View reviewed changes

@alxhub alxhub left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for the compiler side.

However, please check with @IgorMinar - my understanding was that es6-subset exists to limit that surface of ES2015 that we depend on to the bits supported by Closure.

Comment thread packages/compiler/src/core.ts Outdated

@alxhub alxhub Dec 18, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe leave a comment here explaining why this is declared as a function. Alternatively, maybe the type of MetadataFactory could be modified to require a constructable type?

@alxhub alxhub requested a review from IgorMinar December 18, 2018 22:55
@alexeagle
build: fix our copy of Array#find typing
9dccf55 
It should be nullable, matching the lib.es2015.d.ts from TypeScript
@mary-poppins

mary-poppins commented Dec 19, 2018

Copy link
Copy Markdown

You can preview eaca317 at https://pr27738-eaca317.ngbuilds.io/.

@alexeagle

alexeagle commented Dec 19, 2018

Copy link
Copy Markdown
Contributor Author

discussed with @IgorMinar yesterday, he agrees with removing the file. I don't think the original intent was Closure compat, it was to try to prevent Angular depending on a full ES2015 polyfill in old browsers. But now we no longer care about that, since no modern browser needs the polyfills.
It's true that we might now find out about breakages in g3sync which we used to discover when type-checking our code, but OTOH we didn't keep the subset up-to-date and are currently restricted from using some valid ES2015 constructs for no good reason.

@alexeagle
build: update to latest rules_typescript
3d06b7c 
This changes our devmode to es2015, so we now depend on the full es2015 typings.
Update a spot in the compiler which assumed es5 downleveling.
@mary-poppins

mary-poppins commented Dec 19, 2018

Copy link
Copy Markdown

You can preview 3d06b7c at https://pr27738-3d06b7c.ngbuilds.io/.

@alfaproject

alfaproject commented Dec 19, 2018

Copy link
Copy Markdown
Contributor

What about IE9?

@alexeagle

alexeagle commented Dec 20, 2018

Copy link
Copy Markdown
Contributor Author

@alfaproject IE9 still needs polyfills - in practice I think we've always said to use the full es6-shim. To be precise, I should have said that the thing we no longer care about is making it possible to use a smaller subset of the polyfills with Angular.

@alfaproject

alfaproject commented Dec 20, 2018

Copy link
Copy Markdown
Contributor

I guess Microsoft doesn't support any IE version except 11 anyway (not even security updates I think).

alexeagle added a commit to alexeagle/angular that referenced this pull request Jan 14, 2019
@alexeagle
build: switch to typescript's es2015 typings
fbc3e38 
Note that this allows Angular to depend on the entirety of the ES2015 API, not just our restricted subset.
This change is needed because our copy of the subset was out-of-date, and prevents us using ES2015 target in dev mode.

This is a subset of angular#27738
@jasonaden jasonaden added the area: build & ci Related the build and CI infrastructure of the project label Jan 24, 2019
@ngbot ngbot Bot added this to the needsTriage milestone Jan 24, 2019
matsko pushed a commit that referenced this pull request Feb 5, 2019
@alexeagle @matsko
build: switch to typescript's es2015 typings (#28134)
dde7e2f 
Note that this allows Angular to depend on the entirety of the ES2015 API, not just our restricted subset.
This change is needed because our copy of the subset was out-of-date, and prevents us using ES2015 target in dev mode.

This is a subset of #27738

PR Close #28134
matsko pushed a commit that referenced this pull request Feb 5, 2019
@alexeagle @matsko
build: switch to typescript's es2015 typings (#28134)
a6fd118 
Note that this allows Angular to depend on the entirety of the ES2015 API, not just our restricted subset.
This change is needed because our copy of the subset was out-of-date, and prevents us using ES2015 target in dev mode.

This is a subset of #27738

PR Close #28134
alexeagle added a commit to alexeagle/angular that referenced this pull request Feb 6, 2019
@alexeagle
build: switch to typescript's es2015 typings
7b3fd46 
Note that this allows Angular to depend on the entirety of the ES2015 API, not just our restricted subset.
This change is needed because our copy of the subset was out-of-date, and prevents us using ES2015 target in dev mode.

This is a subset of angular#27738
@alexeagle alexeagle mentioned this pull request Feb 6, 2019
Closed
matsko pushed a commit that referenced this pull request Feb 6, 2019
@alexeagle @matsko
build: switch to typescript's es2015 typings (#28570)
8908156 
Note that this allows Angular to depend on the entirety of the ES2015 API, not just our restricted subset.
This change is needed because our copy of the subset was out-of-date, and prevents us using ES2015 target in dev mode.

This is a subset of #27738

PR Close #28570
matsko pushed a commit that referenced this pull request Feb 6, 2019
@alexeagle @matsko
build: switch to typescript's es2015 typings (#28570)
6709db9 
Note that this allows Angular to depend on the entirety of the ES2015 API, not just our restricted subset.
This change is needed because our copy of the subset was out-of-date, and prevents us using ES2015 target in dev mode.

This is a subset of #27738

PR Close #28570
@gregmagolan gregmagolan mentioned this pull request Feb 8, 2019
Closed
@gregmagolan

gregmagolan commented Feb 8, 2019

Copy link
Copy Markdown
Contributor

Replaced by #28625

@gregmagolan gregmagolan closed this Feb 8, 2019
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 14, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alxhub alxhub alxhub approved these changes

@IgorMinar IgorMinar Awaiting requested review from IgorMinar

Assignees

No one assigned

Labels

area: build & ci Related the build and CI infrastructure of the project cla: yes

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

7 participants

@alexeagle @mary-poppins @alfaproject @gregmagolan @alxhub @jasonaden @googlebot