Skip to content

docs: update rxjs example and change fromPromise to from - #27443

Closed
zhengkai wants to merge 1 commit into
angular:masterfrom
zhengkai:fix-rxjs-example
Closed

docs: update rxjs example and change fromPromise to from #27443
zhengkai wants to merge 1 commit into
angular:masterfrom
zhengkai:fix-rxjs-example

Conversation

@zhengkai

@zhengkai zhengkai commented Dec 3, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

the first example at https://angular.io/guide/rx-library, fromPromise is outdated
ReactiveX/rxjs-tslint#7

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

in rxjs, fromPromise is outdated
just a tiny change

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@zhengkai zhengkai changed the title fix(doc) rxjs example, rename fromPromise to from docs: rxjs example, rename fromPromise to from Dec 6, 2018
@brandonroberts brandonroberts added comp: docs effort1: hours target: patch This PR is targeted for the next patch release risk: low state: community Someone from the Angular community is working on this issue or submitted this PR refactoring Issue that involves refactoring or code-cleanup labels Dec 11, 2018
@ngbot ngbot Bot added this to the Backlog milestone Dec 11, 2018
@brandonroberts brandonroberts self-assigned this Dec 11, 2018
@brandonroberts brandonroberts added action: review The PR is still awaiting reviews from at least one requested reviewer area: router labels Dec 11, 2018
@brandonroberts brandonroberts changed the title docs: rxjs example, rename fromPromise to from docs: update rxjs example and change fromPromise to from Dec 11, 2018
@brandonroberts
brandonroberts removed the request for review from IgorMinar December 28, 2018 15:06
@brandonroberts brandonroberts added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 28, 2018
@brandonroberts

brandonroberts commented Dec 28, 2018

Copy link
Copy Markdown
Contributor

Caretaker note: All approvals have been submitted, but pullapprove won't update the status.

gkalpak
gkalpak previously requested changes Dec 28, 2018
View reviewed changes

@gkalpak gkalpak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one more mention of fromPromise in rx-library.md. I think it should be removed as well.

Also, not directly related to this PR, but the simple-creation.ts file doesn't seem to be valid (e.g. it has static imports that are not at the top).
Why is that? Why isn't something failing due to that on CI 🤔

@gkalpak gkalpak added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Dec 28, 2018
@benlesh benlesh added the action: merge The PR is ready for merge by the caretaker label Jan 8, 2019
@benlesh

benlesh commented Jan 8, 2019

Copy link
Copy Markdown
Contributor

@gkalpak regarding your review, can you submit a separate PR to fix that issue? I think this one is good as-is to get in.

@benlesh benlesh removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jan 8, 2019
@benlesh
benlesh dismissed gkalpak’s stale review January 8, 2019 23:28

We can have a separate PR to resolve the other issue.

@kara kara closed this in f6c91c5 Jan 9, 2019
kara pushed a commit that referenced this pull request Jan 9, 2019
@zhengkai @kara
docs: update rxjs example and change fromPromise to from (#27443)
e1538fd 
the first example at https://angular.io/guide/rx-library,
ReactiveX/rxjs-tslint#7

PR Close #27443
gkalpak added a commit to gkalpak/angular that referenced this pull request Jan 9, 2019
@gkalpak
docs: remove deprecated fromPromise from RxJS guide
bcc176f 
Follow-up to angular#27443.
@gkalpak gkalpak mentioned this pull request Jan 9, 2019
Closed
AndrewKushnir pushed a commit that referenced this pull request Jan 9, 2019
@gkalpak @AndrewKushnir
docs: remove deprecated fromPromise from RxJS guide (#28015)
e5f5ad3 
Follow-up to #27443.

PR Close #28015
AndrewKushnir pushed a commit that referenced this pull request Jan 9, 2019
@gkalpak @AndrewKushnir
docs: remove deprecated fromPromise from RxJS guide (#28015)
d0c3e25 
Follow-up to #27443.

PR Close #28015
AndrewKushnir pushed a commit that referenced this pull request Jan 16, 2019
@zhengkai @AndrewKushnir
docs: update rxjs example and change fromPromise to from (#27443)
354f363 
the first example at https://angular.io/guide/rx-library,
ReactiveX/rxjs-tslint#7

PR Close #27443
AndrewKushnir pushed a commit that referenced this pull request Jan 16, 2019
@gkalpak @AndrewKushnir
docs: remove deprecated fromPromise from RxJS guide (#28015)
a6153ac 
Follow-up to #27443.

PR Close #28015
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 14, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
@zhengkai
zhengkai deleted the fix-rxjs-example branch September 16, 2019 03:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers
@brandonroberts brandonroberts brandonroberts approved these changes
@jasonaden jasonaden jasonaden approved these changes
@benlesh benlesh benlesh approved these changes
@gkalpak gkalpak gkalpak left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@brandonroberts brandonroberts

Labels

action: merge The PR is ready for merge by the caretaker area: router cla: yes effort1: hours refactoring Issue that involves refactoring or code-cleanup risk: low state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

6 participants

@zhengkai @brandonroberts @benlesh @jasonaden @gkalpak @googlebot