Skip to content

fix(ivy): taking "interpolation" config option into account (FW-723) - #27363

Closed
AndrewKushnir wants to merge 11 commits into
angular:masterfrom
AndrewKushnir:FW-723_interpolation_config_2
Closed

AndrewKushnir wants to merge 11 commits into
angular:masterfrom
AndrewKushnir:FW-723_interpolation_config_2

Conversation

@AndrewKushnir

Copy link
Copy Markdown
Contributor

This PR introduces support for interpolation config option that you can define at @Component level. Corresponding tests were added and the TestBed one was unblocked.

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature

Does this PR introduce a breaking change?

  • Yes
  • No

@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release comp: ivy labels Nov 30, 2018
@AndrewKushnir
AndrewKushnir requested a review from alxhub November 30, 2018 01:46
@ngbot ngbot Bot added this to the needsTriage milestone Nov 30, 2018
@angular angular deleted a comment from mary-poppins Nov 30, 2018
@angular angular deleted a comment from mary-poppins Nov 30, 2018
Comment thread packages/core/BUILD.bazel Resolved
@AndrewKushnir
AndrewKushnir force-pushed the FW-723_interpolation_config_2 branch 2 times, most recently from 00d38d8 to 2c1fd39 Compare November 30, 2018 18:55
@AndrewKushnir
AndrewKushnir force-pushed the FW-723_interpolation_config_2 branch from 2c1fd39 to 3dc0b00 Compare November 30, 2018 23:32
@angular angular deleted a comment from mary-poppins Dec 1, 2018
@angular angular deleted a comment from mary-poppins Dec 1, 2018
@angular angular deleted a comment from mary-poppins Dec 1, 2018
@angular angular deleted a comment from mary-poppins Dec 1, 2018
@mary-poppins

Copy link
Copy Markdown

You can preview 6236107 at https://pr27363-6236107.ngbuilds.io/.

@alxhub alxhub left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AndrewKushnir

Copy link
Copy Markdown
Contributor Author

Thanks for the review @alxhub!

@AndrewKushnir

Copy link
Copy Markdown
Contributor Author

Presubmit

@angular angular deleted a comment from mary-poppins Dec 4, 2018
@angular angular deleted a comment from mary-poppins Dec 4, 2018
@mary-poppins

Copy link
Copy Markdown

You can preview 0c074f2 at https://pr27363-0c074f2.ngbuilds.io/.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: merge The PR is ready for merge by the caretaker labels Dec 4, 2018
@mhevery mhevery added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 4, 2018
@IgorMinar IgorMinar closed this in 8e644d9 Dec 4, 2018
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants