ivy+docs-infra: compile angular.io with Ivy by gkalpak · Pull Request #26947 · angular/angular

gkalpak · 2018-11-05T17:26:17Z

PR Checklist

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
~~Docs have been added / updated (for bug fixes / features)~~

PR Type

Bugfix
Build related changes
CI related changes
angular.io application / infrastructure changes

What is the new behavior?

Being able to build the angular.io app with Ivy and having a CircleCI job that does that.
(This is a prerequisite for running the app and tests with Ivy.)

Does this PR introduce a breaking change?

Yes
No

Other information

Previously blocking issues:

Fixed by feat(ivy): implement listing lazy routes in ngtsc #27697.
Lazy routes are currently ignored by ngtsc: program.ts#L133
This is not breaking compilation, but results in only a subset of the app being compiled.

Fixed by fix(ivy): ensure unique template and listener function identifiers #27766.
The compiler generates non-unique template function names (according to the nesting path of the element): template.ts#L787-L788
This affects the search-results component, which happens to have two instances of div > ul > li > a > span *ngIf in its template:

ERROR in ./src/app/shared/search-results/search-results.component.ts 60:9
Module parse failed: Identifier '_div_li_span_Template_2' has already been declared (60:9)
You may need an appropriate loader to handle this file type.
|     }
| }
> function _div_li_span_Template_2(rf, ctx) {
|     if (rf & 1) {
|         i0.ɵelementStart(0, "span");

Fixed by fix(ivy): ngcc should not emit TypeScript syntax #27051.
We may emit TS code into JS files.
Fixed by fix(ivy): validate props and attrs with "on" prefix at runtime #28054.
Includes a workaround for FW-786, although this is now also resolved.

googlebot · 2018-11-05T17:46:53Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

mary-poppins · 2018-11-05T17:51:05Z

You can preview 5081b88 at https://pr26947-5081b88.ngbuilds.io/.

mary-poppins · 2018-11-05T18:07:53Z

You can preview f171704 at https://pr26947-f171704.ngbuilds.io/.

mary-poppins · 2018-11-05T18:24:54Z

You can preview d932c8e at https://pr26947-d932c8e.ngbuilds.io/.

mary-poppins · 2018-11-05T19:20:01Z

You can preview 4fca77d at https://pr26947-4fca77d.ngbuilds.io/.

mary-poppins · 2018-11-12T11:27:08Z

You can preview a280312 at https://pr26947-a280312.ngbuilds.io/.

mary-poppins · 2018-11-12T14:33:21Z

You can preview 607d1e4 at https://pr26947-607d1e4.ngbuilds.io/.

mary-poppins · 2018-11-12T14:52:59Z

You can preview f73d37d at https://pr26947-f73d37d.ngbuilds.io/.

mary-poppins · 2018-11-12T15:44:58Z

You can preview 82404d5 at https://pr26947-82404d5.ngbuilds.io/.

mary-poppins · 2018-11-12T16:53:38Z

You can preview 76740f3 at https://pr26947-76740f3.ngbuilds.io/.

petebacondarwin · 2019-01-24T13:46:01Z

refactor(docs-infra): get rid of oncomponent input commit is no longer needed thanks to fix(ivy): validate props and attrs with "on" prefix at runtime #28054.

petebacondarwin

LGTM - you should be able to remove that one workaround commit.

gkalpak · 2019-01-24T14:01:02Z

refactor(docs-infra): get rid of on component input commit is no longer needed thanks to #28054.

I'd prefer to keep it anyway, because I think it is a good change.

mhevery · 2019-01-25T00:35:35Z

http://test/OCL:230813412:BASE:230813487:1548376526150:743db552

IgorMinar

Awesome work!

gkalpak · 2019-01-25T10:10:41Z

merge-assistance: Requires g3sync (or maybe it doesn't: #26947 (comment))

IgorMinar · 2019-01-27T04:43:49Z

I missed this before. This is an ok workaround for now, but we should work on removing this flag.

see angular/angular-cli#13524 (review) for more context.

…n ngcc

Compiling with Ivy doesn't seem to allow input names starting with `on`.

Jira: FW-552

… from `cli-hello-world` in logs

This helps debug issues on CI.

…r ES5 in ngcc

angular-automatic-lock-bot · 2019-09-14T15:22:49Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Nov 5, 2018

gkalpak added state: WIP comp: docs-infra target: patch This PR is targeted for the next patch release labels Nov 5, 2018

ngbot Bot added this to the needsTriage milestone Nov 5, 2018

gkalpak force-pushed the ci-aio-compile-with-ivy branch 2 times, most recently from cb4d25c to 5081b88 Compare November 5, 2018 17:46

googlebot added cla: no and removed cla: yes labels Nov 5, 2018

gkalpak force-pushed the ci-aio-compile-with-ivy branch 2 times, most recently from b91ae3c to f171704 Compare November 5, 2018 18:02

gkalpak force-pushed the ci-aio-compile-with-ivy branch from f171704 to d932c8e Compare November 5, 2018 18:20

gkalpak force-pushed the ci-aio-compile-with-ivy branch from d932c8e to 4fca77d Compare November 5, 2018 19:15

gkalpak force-pushed the ci-aio-compile-with-ivy branch from 4fca77d to a280312 Compare November 12, 2018 11:23

gkalpak force-pushed the ci-aio-compile-with-ivy branch from a280312 to 607d1e4 Compare November 12, 2018 14:29

gkalpak force-pushed the ci-aio-compile-with-ivy branch from 607d1e4 to f73d37d Compare November 12, 2018 14:48

gkalpak force-pushed the ci-aio-compile-with-ivy branch from f73d37d to 82404d5 Compare November 12, 2018 15:40

gkalpak force-pushed the ci-aio-compile-with-ivy branch from 82404d5 to 76740f3 Compare November 12, 2018 16:49

gkalpak force-pushed the ci-aio-compile-with-ivy branch from 76740f3 to 0a2cedb Compare November 12, 2018 20:12

gkalpak requested a review from a team January 24, 2019 12:32

gkalpak mentioned this pull request Jan 24, 2019

refactor(core): remove duplicate check in defaultStyleSanitizer #28292

Closed

3 of 6 tasks

petebacondarwin approved these changes Jan 24, 2019

View reviewed changes

petebacondarwin added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 24, 2019

gkalpak changed the title ~~ci(docs-infra): compile with Ivy~~ ivy+docs-infra: compile angular.io with Ivy Jan 24, 2019

gkalpak force-pushed the ci-aio-compile-with-ivy branch from 911c83b to 21f466c Compare January 24, 2019 17:10

gkalpak added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 24, 2019

petebacondarwin approved these changes Jan 24, 2019

View reviewed changes

mhevery approved these changes Jan 25, 2019

View reviewed changes

IgorMinar approved these changes Jan 25, 2019

View reviewed changes

gkalpak mentioned this pull request Jan 25, 2019

ngcc: Duplicate export 'HttpClientXsrfModule' in fesm5/http.js #28068

Closed

IgorMinar reviewed Jan 27, 2019

View reviewed changes

gkalpak added 9 commits January 28, 2019 22:32

refactor(core): remove duplicate check in defaultStyleSanitizer

ca50c73

fix(ivy): add missing private render3 exports

d4b85f5

fix(ivy): return correct declaration for class indentifiers for ES5 i…

76e2e2c

…n ngcc

refactor(docs-infra): get rid of on component input

f520ef0

Compiling with Ivy doesn't seem to allow input names starting with `on`.

build(docs-infra): upgrade @angular/cli to 7.2.1

5b679e1

ci(docs-infra): compile with Ivy

4225a89

Jira: FW-552

refactor: correctly name cli-hello-world-ivy project to distinguish…

e5aa29d

… from `cli-hello-world` in logs

test: log cli version in cli-hello-world[-ivy] integration projects

54b33bd

This helps debug issues on CI.

fixup! fix(ivy): return correct declaration for class indentifiers fo…

cb9d93a

…r ES5 in ngcc

This was referenced Jan 29, 2019

[7.2.x] ivy+docs-infra: compile angular.io with Ivy #28419

Closed

[7.2.x] ivy+docs-infra: compile angular.io with Ivy #28420

Closed

[7.2.x] ivy+docs-infra: compile angular.io with Ivy #28421

Closed

Conversation

gkalpak commented Nov 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

PR Type

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Uh oh!

googlebot commented Nov 5, 2018

Uh oh!

mary-poppins commented Nov 5, 2018

Uh oh!

mary-poppins commented Nov 5, 2018

Uh oh!

mary-poppins commented Nov 5, 2018

Uh oh!

mary-poppins commented Nov 5, 2018

Uh oh!

mary-poppins commented Nov 12, 2018

Uh oh!

mary-poppins commented Nov 12, 2018

Uh oh!

mary-poppins commented Nov 12, 2018

Uh oh!

mary-poppins commented Nov 12, 2018

Uh oh!

mary-poppins commented Nov 12, 2018

Uh oh!

petebacondarwin commented Jan 24, 2019

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

gkalpak commented Jan 24, 2019

Uh oh!

mhevery commented Jan 25, 2019

Uh oh!

IgorMinar left a comment

Choose a reason for hiding this comment

Uh oh!

gkalpak commented Jan 25, 2019

Uh oh!

IgorMinar Jan 27, 2019

Choose a reason for hiding this comment

Uh oh!

IgorMinar Jan 27, 2019

Choose a reason for hiding this comment

Uh oh!

angular-automatic-lock-bot Bot commented Sep 14, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

gkalpak commented Nov 5, 2018 •

edited

Loading