Repository navigation
Conversation
|
You can preview 28f2e2a at https://pr26382-28f2e2a.ngbuilds.io/. |
There was a problem hiding this comment.
I guess you can delete the compiler comment now since that PR has been merged
There was a problem hiding this comment.
good point deleted.
There was a problem hiding this comment.
We realized that the current implementation was flawed. Should have a fix soon.
There was a problem hiding this comment.
If this is about <ng-container ngProjectAs="..."> it should work now. We should just verify that there is a test in place for this.
There was a problem hiding this comment.
(keyup.enter) works in the current view engine so we should preserve this functionality, otherwise this is a breaking change.
There was a problem hiding this comment.
Yes, but it is all existing functionality from Renderer2 and so I don't think we need to track it here.
There was a problem hiding this comment.
All the gestures with hammer.js work today so we should either preserve this or designed an alternative (hammer.js seems to be getting outdated and not maintained those days, if I'm not mistaken).
There was a problem hiding this comment.
same as above comment.
pkozlowski-opensource
left a comment
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM with the latest fixup.
mhevery
added
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
| | `injectElementRef()` | ✅ | ✅ | ✅ | | ||
| | `injectViewContainerRef()` | ✅ | ✅ | ✅ | | ||
| | `injectTemplateRef()` | ✅ | ✅ | ✅ | | ||
| | `injectRenderer2()` | ✅ | ✅ | ✅ | |
| | `directiveInject(Type)` | ✅ | ✅ | ❌ | | ||
| | `directiveInject(Type)` | ✅ | ✅ | ✅ | | ||
| | `inject(Type, SkipSelf)` | ❌ | ❌ | ❌ | | ||
| | `attribute('name')` | ✅ | ✅ | ❌ | |
There was a problem hiding this comment.
Isn't it injectAttribute()?
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.