Skip to content

fix(ivy): Renderer2 should not use a special injection fn - #26369

Closed
pkozlowski-opensource wants to merge 1 commit into
angular:masterfrom
pkozlowski-opensource:ivy_inject_Renderer2
Closed

pkozlowski-opensource wants to merge 1 commit into
angular:masterfrom
pkozlowski-opensource:ivy_inject_Renderer2

Conversation

@pkozlowski-opensource

Copy link
Copy Markdown
Member

Like #26064 but for Renderer2

@mary-poppins

Copy link
Copy Markdown

You can preview f0f2eb5 at https://pr26369-f0f2eb5.ngbuilds.io/.

@pkozlowski-opensource pkozlowski-opensource added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release comp: ivy labels Oct 10, 2018
@mary-poppins

Copy link
Copy Markdown

You can preview 5a91e27 at https://pr26369-5a91e27.ngbuilds.io/.

@pkozlowski-opensource

Copy link
Copy Markdown
Member Author

I've verified that it fixes Renderer2 injection under TestBed with ivy enabled.

@pkozlowski-opensource

Copy link
Copy Markdown
Member Author

Note: CI failrue is a flake, see #26366

@kara kara left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 10, 2018
@kara

kara commented Oct 10, 2018

Copy link
Copy Markdown
Contributor

presubmit

@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Oct 10, 2018
@ngbot

ngbot Bot commented Oct 10, 2018

Copy link
Copy Markdown

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing
    pending status "google3" is pending
    pending status "code-review/pullapprove" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@pkozlowski-opensource

Copy link
Copy Markdown
Member Author

I'm flagging this one with merge-assistance as the TravisCI is failing for reasons unrelated to this PR (see #26366).

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants