Test bed with context discovery by pkozlowski-opensource · Pull Request #26211 · angular/angular

pkozlowski-opensource · 2018-10-02T14:12:11Z

This PR re-implements TestBed for ivy on top of context discovery. Please review only the last commit ( refactor(ivy): use context discovery in TestBed implementation) - the 2 first ones are part of existing PRs #26113 and #26210

mhevery · 2018-10-03T04:19:05Z

The Last SHA LGTM

mary-poppins · 2018-10-08T10:09:11Z

You can preview 8b69fd4 at https://pr26211-8b69fd4.ngbuilds.io/.

mary-poppins · 2018-10-08T10:44:13Z

You can preview b473dd7 at https://pr26211-b473dd7.ngbuilds.io/.

mary-poppins · 2018-10-09T09:21:02Z

You can preview 9f0923c at https://pr26211-9f0923c.ngbuilds.io/.

mary-poppins · 2018-10-09T09:42:14Z

You can preview 28293c3 at https://pr26211-28293c3.ngbuilds.io/.

mary-poppins · 2018-10-09T11:14:18Z

You can preview d144989 at https://pr26211-d144989.ngbuilds.io/.

mary-poppins · 2018-10-09T11:46:09Z

You can preview 74fa57f at https://pr26211-74fa57f.ngbuilds.io/.

mary-poppins · 2018-10-09T12:35:38Z

You can preview fbb1cb7 at https://pr26211-fbb1cb7.ngbuilds.io/.

pkozlowski-opensource · 2018-10-09T12:36:25Z

Changes to this file are due to the flaky e2e tests that seem to be unrelated to this PR as I saw it on other, completely different PRs, ex.:

https://circleci.com/gh/angular/angular/84387 from fix(upgrade): properly destroy upgraded component elements and descendants #26209 (comment)).

https://circleci.com/gh/angular/angular/84352 from refactor(ivy): merge directives into LViewData #26316

https://circleci.com/gh/angular/angular/84325 from fix(ivy): removing false-negative assert in getOrCreateNodeInjector function #26305

Seems like getText() is async and we wait for on it in other tests:

angular/integration/bazel/test/e2e/app.spec.ts

Line 9 in 9623e7c

div.getText().then(t => expect(t).toEqual(`Hello world!`));

Maybe @robwormald has additional input here - my Protractor kung-fu is too weak here...

getText() is indeed async, but (theoretically at least) waiting shouldn't make any difference (because Protractor will internally wait for async WebDriver methods before checking assertions).
This test is indeed quite flakey lately. If this change makes it less flakey, \o/

Apparently, many people have found this workaround useful. Maybe worth trying (if promise chaining doesn't make a difference).

mary-poppins · 2018-10-09T12:54:09Z

You can preview 646c714 at https://pr26211-646c714.ngbuilds.io/.

mary-poppins · 2018-10-09T13:19:12Z

You can preview c410d67 at https://pr26211-c410d67.ngbuilds.io/.

mhevery · 2018-10-09T18:51:40Z

http://test/OCL:216393026:BASE:216393193:1539110404855:db93666

mary-poppins · 2018-10-10T09:34:36Z

You can preview be28148 at https://pr26211-be28148.ngbuilds.io/.

angular-automatic-lock-bot · 2019-09-14T03:52:37Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Oct 2, 2018

pkozlowski-opensource added state: WIP action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release comp: ivy labels Oct 2, 2018

pkozlowski-opensource force-pushed the test_bed_with_context_discovery branch from 3316be8 to eba6795 Compare October 2, 2018 14:14

pkozlowski-opensource mentioned this pull request Oct 2, 2018

fix(ivy): expose module injector ivy's TestBed impl #25685

Closed

pkozlowski-opensource force-pushed the test_bed_with_context_discovery branch from eba6795 to 2bedc95 Compare October 2, 2018 14:27

pkozlowski-opensource force-pushed the test_bed_with_context_discovery branch 4 times, most recently from 70c5497 to b885930 Compare October 8, 2018 08:52

angular deleted a comment from mary-poppins Oct 8, 2018

pkozlowski-opensource removed the state: WIP label Oct 8, 2018

pkozlowski-opensource force-pushed the test_bed_with_context_discovery branch from b885930 to 821af4d Compare October 8, 2018 09:17

angular deleted a comment from mary-poppins Oct 8, 2018

pkozlowski-opensource force-pushed the test_bed_with_context_discovery branch from 821af4d to 8b69fd4 Compare October 8, 2018 10:04

pkozlowski-opensource force-pushed the test_bed_with_context_discovery branch from 8b69fd4 to b473dd7 Compare October 8, 2018 10:39

pkozlowski-opensource added the state: WIP label Oct 8, 2018

pkozlowski-opensource force-pushed the test_bed_with_context_discovery branch from b473dd7 to 9f0923c Compare October 9, 2018 09:16

pkozlowski-opensource force-pushed the test_bed_with_context_discovery branch from 9f0923c to 28293c3 Compare October 9, 2018 09:38

pkozlowski-opensource removed the state: WIP label Oct 9, 2018

pkozlowski-opensource force-pushed the test_bed_with_context_discovery branch from 28293c3 to d144989 Compare October 9, 2018 11:09

pkozlowski-opensource force-pushed the test_bed_with_context_discovery branch from d144989 to 74fa57f Compare October 9, 2018 11:41

pkozlowski-opensource force-pushed the test_bed_with_context_discovery branch from 74fa57f to fbb1cb7 Compare October 9, 2018 12:31

pkozlowski-opensource commented Oct 9, 2018

View reviewed changes

pkozlowski-opensource force-pushed the test_bed_with_context_discovery branch from fbb1cb7 to 646c714 Compare October 9, 2018 12:49

pkozlowski-opensource force-pushed the test_bed_with_context_discovery branch from 646c714 to c410d67 Compare October 9, 2018 13:14

mhevery approved these changes Oct 9, 2018

View reviewed changes

pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 9, 2018

pkozlowski-opensource force-pushed the test_bed_with_context_discovery branch from c410d67 to be28148 Compare October 10, 2018 09:30

refactor(ivy): use context discovery in TestBed implementation

be28148

mhevery closed this in 053bf27 Oct 11, 2018

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019

Conversation

pkozlowski-opensource commented Oct 2, 2018

Uh oh!

mhevery commented Oct 3, 2018

Uh oh!

mary-poppins commented Oct 8, 2018

Uh oh!

mary-poppins commented Oct 8, 2018

Uh oh!

mary-poppins commented Oct 9, 2018

Uh oh!

mary-poppins commented Oct 9, 2018

Uh oh!

mary-poppins commented Oct 9, 2018

Uh oh!

mary-poppins commented Oct 9, 2018

Uh oh!

mary-poppins commented Oct 9, 2018

Uh oh!

pkozlowski-opensource Oct 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pkozlowski-opensource Oct 9, 2018

Choose a reason for hiding this comment

Uh oh!

gkalpak Oct 9, 2018

Choose a reason for hiding this comment

Uh oh!

gkalpak Oct 9, 2018

Choose a reason for hiding this comment

Uh oh!

mary-poppins commented Oct 9, 2018

Uh oh!

mary-poppins commented Oct 9, 2018

Uh oh!

mhevery commented Oct 9, 2018

Uh oh!

mary-poppins commented Oct 10, 2018

Uh oh!

angular-automatic-lock-bot Bot commented Sep 14, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pkozlowski-opensource Oct 9, 2018 •

edited

Loading