Skip to content

ci(docs-infra): run the script in the correct folder - #26136

Merged
alxhub merged 1 commit into
angular:masterfrom
petebacondarwin:aio-fix-test-preview-job
Sep 27, 2018
Merged

ci(docs-infra): run the script in the correct folder#26136
alxhub merged 1 commit into
angular:masterfrom
petebacondarwin:aio-fix-test-preview-job

Conversation

@petebacondarwin

@petebacondarwin petebacondarwin commented Sep 27, 2018

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@petebacondarwin petebacondarwin added type: bug/fix action: review The PR is still awaiting reviews from at least one requested reviewer freq4: critical severity3: broken target: patch This PR is targeted for the next patch release risk: high labels Sep 27, 2018
gkalpak
gkalpak approved these changes Sep 27, 2018
View reviewed changes

@gkalpak gkalpak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😇

@petebacondarwin petebacondarwin added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed risk: high action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 27, 2018
@petebacondarwin

petebacondarwin commented Sep 27, 2018

Copy link
Copy Markdown
Contributor Author

Caretaker: this change only affects AIO so George's PullApprove should be enough. Feel free to get a Googler to double check.

This was referenced Sep 27, 2018
Closed
Closed
@alxhub
alxhub merged commit eeebe28 into angular:master Sep 27, 2018
@gkalpak gkalpak mentioned this pull request Oct 1, 2018
Closed
@petebacondarwin
petebacondarwin deleted the aio-fix-test-preview-job branch October 15, 2018 15:12
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 14, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@gkalpak gkalpak gkalpak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes freq4: critical merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release type: bug/fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@petebacondarwin @gkalpak @alxhub @googlebot