Skip to content

Conversation

@vicb
Copy link
Contributor

@vicb vicb commented Jun 18, 2015

fixes #1694

@vicb
Copy link
Contributor Author

vicb commented Jun 18, 2015

@naomiblack @tbosch

This PR contains a fix for #1694 on the current code base because it is high priority for GT.

Some tests are failing because relative URL are not yet supported in templates (that's the pending #2593 which won't be ready before next week) - and it might also be related to the workaround @jelbourn put in place to be able to test the material examples.

I'm wondering if GT does not use a custom UrlResolver which supports relative URL resolution ? If this is the case, we might want to merge this by disabling the failing tests for now (and re-enable them once 2593 is ready).

@yjbanov
Copy link
Contributor

yjbanov commented Jun 18, 2015

Why do we need relative URL support for inlining? The two should be orthogonal concerns.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need this field? The super-class already has it.

@yjbanov
Copy link
Contributor

yjbanov commented Jun 20, 2015

superseded by #2654

@yjbanov yjbanov closed this Jun 20, 2015
@vicb
Copy link
Contributor Author

vicb commented Jun 20, 2015

@yjbanov thanks for looking at this & fixing

@vicb vicb deleted the 0618-inline branch December 3, 2015 16:54
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wait for included css to be fully loaded before instantiating a component / finishing the compilation

4 participants