Repository navigation
feat(ivy): add ability to inspect local refs through context discovery - #26117
pkozlowski-opensource wants to merge 1 commit into
Conversation
pkozlowski-opensource
added
action: review
|
You can preview f797bd5 at https://pr26117-f797bd5.ngbuilds.io/. |
There was a problem hiding this comment.
I think this should be 3 consts and 0 vars, no?
There was a problem hiding this comment.
I think we want to wrap lViewData[lNodeIndex] with readElementValue in case that element happens to have a styling context. You might want to use getLNode(), since it has that built in. (Maybe a test for this?)
There was a problem hiding this comment.
What about local refs on ng-template elements? Is that something we want to support?
There was a problem hiding this comment.
Right. I don't need it for TestBed but we should add it for completeness + a test. Thnx for catching this!
There was a problem hiding this comment.
FWIW, if it's not necessary for TestBed, we could probably just make a JIRA ticket for later. Was just curious what your thoughts were on supporting it down the line.
matsko
left a comment
matsko
left a comment
There was a problem hiding this comment.
This is an excellent feature.
mhevery
left a comment
mhevery
left a comment
There was a problem hiding this comment.
LGTM, please take care of the comments.
There was a problem hiding this comment.
nit: /** should not have text after it. (insert line break).
mhevery
added
action: cleanup
43bd538 to
725b4a3
Compare
|
You can preview 43bd538 at https://pr26117-43bd538.ngbuilds.io/. |
|
You can preview 725b4a3 at https://pr26117-725b4a3.ngbuilds.io/. |
pkozlowski-opensource
removed
the
action: cleanup
725b4a3 to
fa0ec85
Compare
|
You can preview fa0ec85 at https://pr26117-fa0ec85.ngbuilds.io/. |
pkozlowski-opensource
added
the
merge: caretaker note
|
Marking as merge-assistance since:
|
fa0ec85 to
8f522ba
Compare
|
You can preview 8f522ba at https://pr26117-8f522ba.ngbuilds.io/. |
kara
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This is needed for the TestBed implementation since we can ask for a set of local refs on a given debug element.