Skip to content

fix(ivy): objects like ElementRef should not use a special injection fn - #26064

Closed
kara wants to merge 4 commits into
angular:masterfrom
kara:elementRef
Closed

fix(ivy): objects like ElementRef should not use a special injection fn#26064
kara wants to merge 4 commits into
angular:masterfrom
kara:elementRef

Conversation

@kara

@kara kara commented Sep 21, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@kara
kara force-pushed the elementRef branch 3 times, most recently from 14f8102 to 5b4b8c4 Compare September 22, 2018 00:16
@angular angular deleted a comment from mary-poppins Sep 22, 2018
@angular angular deleted a comment from mary-poppins Sep 22, 2018
@angular angular deleted a comment from mary-poppins Sep 22, 2018
@angular angular deleted a comment from mary-poppins Sep 22, 2018
@angular angular deleted a comment from mary-poppins Sep 22, 2018
@angular angular deleted a comment from mary-poppins Sep 22, 2018
@angular angular deleted a comment from mary-poppins Sep 22, 2018
@kara kara added target: major This PR is targeted for the next major release comp: ivy type: bug/fix labels Sep 22, 2018
@kara
kara force-pushed the elementRef branch 2 times, most recently from b408b72 to 0a83be4 Compare September 22, 2018 01:26
@angular angular deleted a comment from mary-poppins Sep 22, 2018
@angular angular deleted a comment from mary-poppins Sep 22, 2018
@angular angular deleted a comment from mary-poppins Sep 22, 2018
@angular angular deleted a comment from mary-poppins Sep 22, 2018
@mary-poppins

mary-poppins commented Sep 22, 2018

Copy link
Copy Markdown

You can preview 5ee4b83 at https://pr26064-5ee4b83.ngbuilds.io/.

@mary-poppins

mary-poppins commented Sep 22, 2018

Copy link
Copy Markdown

You can preview 50b1d68 at https://pr26064-50b1d68.ngbuilds.io/.

mhevery
mhevery reviewed Sep 25, 2018
View reviewed changes
Comment thread packages/core/BUILD.bazel Outdated

@mhevery mhevery Sep 25, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reasoning for this change?

@kara kara Sep 25, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compiler switch relies on jit/directive <-- jit/environment <-- render3/index. So any file that has imports/exports in render3/index.ts (most render3 files) is importing into ivy_switch. Separating it out into its own file gives us a bit more flexibility.

@kara
kara force-pushed the elementRef branch 3 times, most recently from 87af032 to 5d06061 Compare September 25, 2018 07:16
@angular angular deleted a comment from mary-poppins Sep 25, 2018
@angular angular deleted a comment from mary-poppins Sep 25, 2018
@angular angular deleted a comment from mary-poppins Sep 25, 2018
@angular angular deleted a comment from mary-poppins Sep 25, 2018
@mary-poppins

mary-poppins commented Sep 25, 2018

Copy link
Copy Markdown

You can preview 89305ed at https://pr26064-89305ed.ngbuilds.io/.

@kara kara added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Sep 25, 2018
@mary-poppins

mary-poppins commented Sep 25, 2018

Copy link
Copy Markdown

You can preview 3ed2a11 at https://pr26064-3ed2a11.ngbuilds.io/.

@mary-poppins

mary-poppins commented Sep 25, 2018

Copy link
Copy Markdown

You can preview bcdd7f2 at https://pr26064-bcdd7f2.ngbuilds.io/.

@kara

kara commented Sep 25, 2018

Copy link
Copy Markdown
Contributor Author

presubmit

@kara kara added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 25, 2018
@kara kara closed this in 6a62ed2 Sep 25, 2018
@pkozlowski-opensource pkozlowski-opensource mentioned this pull request Oct 10, 2018
Closed
@trotyl trotyl mentioned this pull request Oct 13, 2018
Closed
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 14, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JoostK JoostK JoostK left review comments
+2 more reviewers
@mhevery mhevery mhevery approved these changes
@trotyl trotyl trotyl left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release type: bug/fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kara @mary-poppins @mhevery @JoostK @trotyl @googlebot