Repository navigation
Conversation
gkalpak
added
action: review
Member
Author
|
The current CI failures are "inherited" from upstream. (See #25827.) |
`%%DEPLOYMENT_HOST%%` has been assumed to be the host prefix for sitemap URLs since bf29936, but afaict this was never the case. PR Close angular#19795
…ngular#25641) As part of the tests run in the CircleCI `aio_monitoring` job, we need to retrieve `sitemap.xml` from the site under test. Previously, the URL used to retrieve that contained a double-slash (`//`). At some point, Firebase (which is used for hosting the site) stopped normalizing double-slashes to a single slash, causing the test to fail. This commit fixes the problem by ensuring that the constructed URLs do not contain double-slashes. PR Close angular#25641
gkalpak
force-pushed
the
6.1.x-fix-docs-infra-aio_monitoring-CI-job
branch
from
September 6, 2018 05:42
6e61162 to
98663d2
Compare
|
You can preview 98663d2 at https://pr25820-98663d2.ngbuilds.io/. |
petebacondarwin
approved these changes
Sep 6, 2018
gkalpak
added
action: merge
IgorMinar
pushed a commit
that referenced
this pull request
Sep 6, 2018
IgorMinar
pushed a commit
that referenced
this pull request
Sep 6, 2018
…25641) (#25820) As part of the tests run in the CircleCI `aio_monitoring` job, we need to retrieve `sitemap.xml` from the site under test. Previously, the URL used to retrieve that contained a double-slash (`//`). At some point, Firebase (which is used for hosting the site) stopped normalizing double-slashes to a single slash, causing the test to fail. This commit fixes the problem by ensuring that the constructed URLs do not contain double-slashes. PR Close #25641 PR Close #25820
Contributor
|
can you please rebase this PR? thanks |
IgorMinar
added
action: cleanup
Member
Author
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backporting #25641 to 6.1.x. This required backporting the first commit of #19795, which will eventually be backported to 6.1.x anyway.