Repository navigation
Conversation
cexbrayat
force-pushed
the
test/currency-pipe
branch
3 times, most recently
from
July 22, 2018 16:45
1190142 to
08e209c
Compare
Will avoid errors in examples like the one fixed in angular#24661
cexbrayat
force-pushed
the
test/currency-pipe
branch
from
July 22, 2018 17:06
08e209c to
6097ec1
Compare
brandonroberts
added
comp: docs
area: common
ocombe
approved these changes
Jul 23, 2018
jenniferfell
added
state: community
Contributor
vicb
pushed a commit
that referenced
this pull request
Jul 23, 2018
Contributor
|
I had to merge this PR manually because of a conflict on the 6.0.x branch. Thanks for the PR @cexbrayat |
vicb
pushed a commit
that referenced
this pull request
Jul 23, 2018
vicb
added a commit
to vicb/angular
that referenced
this pull request
Jul 24, 2018
A `keyvalue-pipe` was inadvertently pulled in When merging angular#25028 (commit 6eca367). This pipe is NOT in the patch branch and the test fails. This commit remove the faulty spec.
vicb
added a commit
that referenced
this pull request
Jul 24, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The number pipes were not tested in e2e.
What is the new behavior?
This PR adds e2e tests for the number/percent/currency pipe and will avoid errors in examples like the one fixed in #24661
Does this PR introduce a breaking change?