Skip to content

fix(common): format fractional seconds - #24844

Closed
vicb wants to merge 1 commit into
angular:masterfrom
vicb:0711-fixFormatDate
Closed

vicb wants to merge 1 commit into
angular:masterfrom
vicb:0711-fixFormatDate

Conversation

@vicb

@vicb vicb commented Jul 11, 2018 •

Copy link
Copy Markdown
Contributor

fix a bug introduced in #24831

formatDate(3001, 'm:ss.SSS', 'en') was incorrectly returning 3.100

@vicb vicb added type: bug/fix action: review The PR is still awaiting reviews from at least one requested reviewer area: common Issues related to APIs in the @angular/common package target: patch This PR is targeted for the next patch release labels Jul 11, 2018
@vicb
vicb force-pushed the 0711-fixFormatDate branch from c88f07c to 0915e14 Compare July 11, 2018 16:00
@vicb
vicb force-pushed the 0711-fixFormatDate branch from 0915e14 to edb088d Compare July 11, 2018 16:00
@vicb

vicb commented Jul 11, 2018

Copy link
Copy Markdown
Contributor Author

@mary-poppins

Copy link
Copy Markdown

You can preview edb088d at https://pr24844-edb088d.ngbuilds.io/.

@vicb vicb added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 11, 2018
mhevery pushed a commit that referenced this pull request Jul 11, 2018
@mhevery mhevery closed this in 0b4d85e Jul 11, 2018
@vicb
vicb deleted the 0711-fixFormatDate branch August 3, 2018 19:08
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package cla: yes target: patch This PR is targeted for the next patch release type: bug/fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants