Skip to content

docs: architecture overview, fix bad link - #24825

Closed
jbogarthyde wants to merge 1 commit into
angular:masterfrom
jbogarthyde:jb-arch-edit
Closed

docs: architecture overview, fix bad link#24825
jbogarthyde wants to merge 1 commit into
angular:masterfrom
jbogarthyde:jb-arch-edit

Conversation

@jbogarthyde

@jbogarthyde jbogarthyde commented Jul 10, 2018

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ x] No

Other information

@jbogarthyde jbogarthyde added comp: docs action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jul 10, 2018
@jbogarthyde

jbogarthyde commented Jul 10, 2018

Copy link
Copy Markdown
Contributor Author

FIxed a typo - please try again.

@mary-poppins

mary-poppins commented Jul 10, 2018

Copy link
Copy Markdown

You can preview 4e63f01 at https://pr24825-4e63f01.ngbuilds.io/.

@jbogarthyde jbogarthyde mentioned this pull request Jul 11, 2018
Closed
2 of 3 tasks
@jbogarthyde

jbogarthyde commented Jul 12, 2018

Copy link
Copy Markdown
Contributor Author

FIxed a typo in a link - please approve.
@mhevery @jenniferfell

@jbogarthyde jbogarthyde added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 13, 2018
@mary-poppins

mary-poppins commented Jul 13, 2018

Copy link
Copy Markdown

You can preview ce3df66 at https://pr24825-ce3df66.ngbuilds.io/.

@jenniferfell jenniferfell removed the action: merge The PR is ready for merge by the caretaker label Jul 13, 2018
@jenniferfell
jenniferfell requested review from brandonroberts and removed request for mhevery July 13, 2018 17:58
@jenniferfell

jenniferfell commented Jul 13, 2018

Copy link
Copy Markdown
Contributor

LGTM

@brandonroberts : Will you be our pull-approver? Formerly missing a ] so the URL for the link showed up as plain text in the doc. Judy fixed, so now it's a proper linked phrase.

@brandonroberts brandonroberts added the action: merge The PR is ready for merge by the caretaker label Jul 13, 2018
@gkalpak gkalpak mentioned this pull request Jul 14, 2018
Closed
1 task done
@brandonroberts brandonroberts removed the action: merge The PR is ready for merge by the caretaker label Jul 15, 2018
@mary-poppins

mary-poppins commented Jul 16, 2018

Copy link
Copy Markdown

You can preview 51cf61f at https://pr24825-51cf61f.ngbuilds.io/.

@mary-poppins

mary-poppins commented Jul 17, 2018

Copy link
Copy Markdown

You can preview dec5946 at https://pr24825-dec5946.ngbuilds.io/.

@mhevery

mhevery commented Jul 17, 2018

Copy link
Copy Markdown
Contributor

Is this ready to merge? The merge label has been removed...

@brandonroberts

brandonroberts commented Jul 17, 2018

Copy link
Copy Markdown
Contributor

@mhevery it's ready but we can't get CI green. Saucelabs keeps failing.

@jbogarthyde jbogarthyde added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jul 19, 2018
@mhevery mhevery removed the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jul 20, 2018
vicb pushed a commit that referenced this pull request Jul 20, 2018
@jbogarthyde @vicb
docs: fix bad link (#24825)
f2aeb70 
PR Close #24825
@jenniferfell jenniferfell added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jul 20, 2018
@jenniferfell

jenniferfell commented Jul 20, 2018

Copy link
Copy Markdown
Contributor

caretaker: This PR has approval from @brandonroberts, he appears to be in the pull-approve group for the PR, and the PR was not submitted by him, so I would expect code-review-pullapprove to be passing, not stuck pending. Suggestions? Thanks.

@vicb vicb closed this in bb58138 Jul 20, 2018
@jbogarthyde
jbogarthyde deleted the jb-arch-edit branch July 23, 2018 16:33
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 13, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@brandonroberts brandonroberts brandonroberts approved these changes
@jenniferfell jenniferfell jenniferfell approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jbogarthyde @mary-poppins @jenniferfell @mhevery @brandonroberts @googlebot