Skip to content

Revert #24803 on branch 6.0.x - #24809

Closed
gkalpak wants to merge 2 commits into
angular:6.0.xfrom
gkalpak:revert-24803-on-6.0.x
Closed

Revert #24803 on branch 6.0.x#24809
gkalpak wants to merge 2 commits into
angular:6.0.xfrom
gkalpak:revert-24803-on-6.0.x

Conversation

@gkalpak

@gkalpak gkalpak commented Jul 10, 2018

Copy link
Copy Markdown
Member

Reverting PR #24803 on branch 6.0.x, because that PR is a follow-up to PR #19904, which was only merged into master.

@gkalpak gkalpak added area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer PR target: patch-only labels Jul 10, 2018
@gkalpak

gkalpak commented Jul 10, 2018

Copy link
Copy Markdown
Member Author

The CircleCI test failure is inherited from upstream (has been broken since https://circleci.com/gh/angular/angular/53580; probably due to #24759).

gkalpak added 2 commits July 10, 2018 12:24
@gkalpak
Revert "build: remove unnecessary internal-angular karma reporter (a…
52a2ce1 
…ngular#24803)"

This reverts commit d7c4898.
Part of reverting PR angular#24803 on branch `6.0.x`, because that PR is a
follow-up to PR angular#19904, which was only merged into master.
@gkalpak
Revert "build: make internal-angular karma reporter compatible with…
cece80c 
… latest karma (angular#24803)"

This reverts commit 98c509f.
Part of reverting PR angular#24803 on branch `6.0.x`, because that PR is a
follow-up to PR angular#19904, which was only merged into master.
@gkalpak
gkalpak force-pushed the revert-24803-on-6.0.x branch from 0a6eaab to cece80c Compare July 10, 2018 09:25
@mhevery mhevery added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 10, 2018
@ngbot

ngbot Bot commented Jul 10, 2018

Copy link
Copy Markdown

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: test" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

mhevery pushed a commit that referenced this pull request Jul 10, 2018
@gkalpak @mhevery
Revert "build: remove unnecessary internal-angular karma reporter (#…
56712aa 
…24803)" (#24809)

This reverts commit d7c4898.
Part of reverting PR #24803 on branch `6.0.x`, because that PR is a
follow-up to PR #19904, which was only merged into master.

PR Close #24809
mhevery pushed a commit that referenced this pull request Jul 10, 2018
@gkalpak @mhevery
Revert "build: make internal-angular karma reporter compatible with…
59fd91d 
… latest karma (#24803)" (#24809)

This reverts commit 98c509f.
Part of reverting PR #24803 on branch `6.0.x`, because that PR is a
follow-up to PR #19904, which was only merged into master.

PR Close #24809
@mhevery

mhevery commented Jul 10, 2018

Copy link
Copy Markdown
Contributor

merged as ddb792d

@mhevery mhevery closed this Jul 10, 2018
@gkalpak
gkalpak deleted the revert-24803-on-6.0.x branch July 10, 2018 22:28
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 13, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@mhevery mhevery mhevery approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gkalpak @mhevery @googlebot