ngtsc support for @Pipes! by alxhub · Pull Request #24703 · angular/angular

This updates the r3_pipe_compiler to not depend on global analysis, and to produce ngPipeDef instructions in the same way that the other compilers do. It's a precursor to JIT and AOT implementations of @pipe compilation.

Adds support for compiling @pipe in JIT mode, along with tests to verify that certain aspects of compilation are correct.

@NgModule

This commit adds support to ngtsc for compilation of the @pipe annotation, including support for pipes in @NgModule scopes.

mary-poppins · 2018-07-03T21:24:43Z

You can preview b188f8b at https://pr24703-b188f8b.ngbuilds.io/.

This updates the r3_pipe_compiler to not depend on global analysis, and to produce ngPipeDef instructions in the same way that the other compilers do. It's a precursor to JIT and AOT implementations of @pipe compilation. PR Close #24703

Adds support for compiling @pipe in JIT mode, along with tests to verify that certain aspects of compilation are correct. PR Close #24703

@NgModule

This commit adds support to ngtsc for compilation of the @pipe annotation, including support for pipes in @NgModule scopes. PR Close #24703

cexbrayat · 2018-07-03T22:50:37Z

+    }
+    this.scopeRegistry.registerPipe(clazz, pipeName);
+
+    let pure = false;


@alxhub Dumb question as I'm probably missing something but shouldn't that be let pure = true by default as it is currently and in Ivy JiT mode?

I opened PR #24750 in case the pipes should indeed by pure by default.

angular-automatic-lock-bot · 2019-09-13T19:22:10Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Jun 28, 2018

alxhub force-pushed the ngtsc-pipes branch from 55c2f7e to 9f6a025 Compare June 29, 2018 15:48

alxhub force-pushed the ngtsc-pipes branch from 9f6a025 to 7006416 Compare June 29, 2018 18:45

mhevery previously requested changes Jul 2, 2018

View reviewed changes

alxhub added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Jul 2, 2018

alxhub added 6 commits July 3, 2018 14:10

fix(ivy): export the true ComponentDef/DirectiveDef types (not internal)

10b5d3c

This was a bug introduced in a previous commit.

feat(ivy): support pipe compilation from local metadata

1bd5908

This updates the r3_pipe_compiler to not depend on global analysis, and to produce ngPipeDef instructions in the same way that the other compilers do. It's a precursor to JIT and AOT implementations of @pipe compilation.

feat(ivy): JIT support for compilation of @pipes

da1f033

Adds support for compiling @pipe in JIT mode, along with tests to verify that certain aspects of compilation are correct.

feat(ivy): AOT support for compilation of @pipes

de11da9

This commit adds support to ngtsc for compilation of the @pipe annotation, including support for pipes in @NgModule scopes.

fixup! feat(ivy): JIT support for compilation of @pipes

594a856

fixup! feat(ivy): AOT support for compilation of @pipes

b188f8b

alxhub force-pushed the ngtsc-pipes branch from 0598fd9 to b188f8b Compare July 3, 2018 21:15

mhevery closed this in ffbacdf Jul 3, 2018

mhevery pushed a commit that referenced this pull request Jul 3, 2018

feat(ivy): JIT support for compilation of @pipes (#24703)

3d52174

Adds support for compiling @pipe in JIT mode, along with tests to verify that certain aspects of compilation are correct. PR Close #24703

mhevery pushed a commit that referenced this pull request Jul 3, 2018

feat(ivy): AOT support for compilation of @pipes (#24703)

b6af870

This commit adds support to ngtsc for compilation of the @pipe annotation, including support for pipes in @NgModule scopes. PR Close #24703

cexbrayat reviewed Jul 3, 2018

View reviewed changes

cexbrayat mentioned this pull request Jul 3, 2018

fix(ivy): pipes are pure by default #24750

Closed

3 tasks done

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019

Conversation

alxhub commented Jun 28, 2018

Uh oh!

mary-poppins commented Jun 28, 2018

Uh oh!

mary-poppins commented Jun 29, 2018

Uh oh!

mary-poppins commented Jun 29, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mary-poppins commented Jul 2, 2018

Uh oh!

mhevery commented Jul 3, 2018

Uh oh!

mary-poppins commented Jul 3, 2018

Uh oh!

cexbrayat Jul 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

angular-automatic-lock-bot Bot commented Sep 13, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cexbrayat Jul 3, 2018 •

edited

Loading